You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/12 23:31:38 UTC
[GitHub] [beam] chamikaramj opened a new pull request, #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
chamikaramj opened a new pull request, #24642:
URL: https://github.com/apache/beam/pull/24642
This fixes a regression due to https://github.com/apache/beam/pull/14970 which resulted in 'serviceAccount' option not being visible in the Dataflow Cloud Console UI.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #24642:
URL: https://github.com/apache/beam/pull/24642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a diff in pull request #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
Posted by GitBox <gi...@apache.org>.
lukecwik commented on code in PR #24642:
URL: https://github.com/apache/beam/pull/24642#discussion_r1047525389
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -120,7 +120,6 @@
void setDataflowServiceOptions(List<String> options);
/** Run the job as a specific service account, instead of the default GCE robot. */
- @Hidden
Review Comment:
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a diff in pull request #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
Posted by GitBox <gi...@apache.org>.
lukecwik commented on code in PR #24642:
URL: https://github.com/apache/beam/pull/24642#discussion_r1046542170
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -120,7 +120,6 @@
void setDataflowServiceOptions(List<String> options);
/** Run the job as a specific service account, instead of the default GCE robot. */
- @Hidden
Review Comment:
The idea being that you would use `@JsonIgnore` instead of `@Hidden` if we still don't want to make this show up on the worker but show up in the display data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a diff in pull request #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on code in PR #24642:
URL: https://github.com/apache/beam/pull/24642#discussion_r1046555067
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -120,7 +120,6 @@
void setDataflowServiceOptions(List<String> options);
/** Run the job as a specific service account, instead of the default GCE robot. */
- @Hidden
Review Comment:
Yes, this is the service account that would be used by Dataflow workers (and it was shown in UI before the change https://github.com/apache/beam/pull/14970).
This option (--serviceAccount) is advertised under "Specifying a user-managed worker service account" here: https://cloud.google.com/dataflow/docs/concepts/security-and-permissions#worker-service-account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a diff in pull request #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
Posted by GitBox <gi...@apache.org>.
lukecwik commented on code in PR #24642:
URL: https://github.com/apache/beam/pull/24642#discussion_r1046540631
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -120,7 +120,6 @@
void setDataflowServiceOptions(List<String> options);
/** Run the job as a specific service account, instead of the default GCE robot. */
- @Hidden
Review Comment:
Does this coincide with the service account that would be used on GCE?
If so then this LGTM otherwise I believe the intent was to not propagate this value to the worker (the purpose of `@Hidden`) so there wasn't a mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24642: Remove 'Hidden' attribute from serviceAccount PipelineOption
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24642:
URL: https://github.com/apache/beam/pull/24642#issuecomment-1347561156
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org