You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/06 09:47:19 UTC
[GitHub] [skywalking] wayilau opened a new pull request #4184: Close
inputstream.
wayilau opened a new pull request #4184: Close inputstream.
URL: https://github.com/apache/skywalking/pull/4184
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
Close the inpustream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4184: Close
inputstream.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4184: Close inputstream.
URL: https://github.com/apache/skywalking/pull/4184#issuecomment-571087415
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=h1) Report
> Merging [#4184](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f181f7b4830b05c6812878ccd4b23633163ea39a?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `87.5%`.
[](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4184 +/- ##
==========================================
- Coverage 26.84% 26.81% -0.03%
==========================================
Files 1163 1163
Lines 25426 25427 +1
Branches 3691 3692 +1
==========================================
- Hits 6826 6819 -7
- Misses 17991 17998 +7
- Partials 609 610 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4184/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `85.71% <87.5%> (-3.18%)` | :arrow_down: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4184/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4184/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=footer). Last update [f181f7b...3dacda9](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4184: Close
inputstream.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4184: Close inputstream.
URL: https://github.com/apache/skywalking/pull/4184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4184: Close
inputstream.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4184: Close inputstream.
URL: https://github.com/apache/skywalking/pull/4184#issuecomment-571087415
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=h1) Report
> Merging [#4184](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/f181f7b4830b05c6812878ccd4b23633163ea39a?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `87.5%`.
[](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4184 +/- ##
==========================================
- Coverage 26.84% 26.81% -0.03%
==========================================
Files 1163 1163
Lines 25426 25427 +1
Branches 3691 3692 +1
==========================================
- Hits 6826 6819 -7
- Misses 17991 17998 +7
- Partials 609 610 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4184/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `85.71% <87.5%> (-3.18%)` | :arrow_down: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4184/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4184/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=footer). Last update [f181f7b...3dacda9](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4184: Close inputstream.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4184: Close inputstream.
URL: https://github.com/apache/skywalking/pull/4184#issuecomment-571087415
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=h1) Report
> Merging [#4184](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9919d173758c58a666c746cff55947b7419ddc02?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4184 +/- ##
=======================================
Coverage 26.81% 26.81%
=======================================
Files 1163 1163
Lines 25427 25427
Branches 3692 3692
=======================================
Hits 6819 6819
Misses 17998 17998
Partials 610 610
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=footer). Last update [9919d17...3dacda9](https://codecov.io/gh/apache/skywalking/pull/4184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services