You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ugo Matrangolo (JIRA)" <ji...@apache.org> on 2007/04/11 00:01:32 UTC
[jira] Created: (DERBY-2539) convert lang/timestampArith.java to
JUnit
convert lang/timestampArith.java to JUnit
-----------------------------------------
Key: DERBY-2539
URL: https://issues.apache.org/jira/browse/DERBY-2539
Project: Derby
Issue Type: Test
Components: Test
Reporter: Ugo Matrangolo
Assigned To: Ugo Matrangolo
Priority: Minor
convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo reopened DERBY-2539:
-----------------------------------
oops.
Sorry, I erroneously resolved the issue.
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490481 ]
Kathey Marsden commented on DERBY-2539:
---------------------------------------
I think I see what you mean about the fail statements. There are
instances where you catch an exception and then throw it, where just
letting the exception be thrown would suffice.
For example:
+ try {
+ rs.close();
+ } catch (SQLException sqle) {
+ throw sqle;
}
can be written as:
rs.close();
since runTests throws an SQLException
Do you have any objection to my changing these cases before I checkin
the change?
Thanks
Kathey
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490471 ]
Ugo Matrangolo commented on DERBY-2539:
---------------------------------------
Thank you Kathey for getting the time to review my code.
Reading the old test I think that I fail on exception when no exception is expected at all. IMHO getting an exception where no exception is expected is a condition worth of a fail() call as in the old code.
I took advantage of your comment and rebuilded the patch from the source code root.
Thank you,
Ugo.
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2539:
----------------------------------
Attachment: DERBY-2539_stat_210407.txt
DERBY-2539_diff_210407.txt
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo resolved DERBY-2539.
-----------------------------------
Resolution: Fixed
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490514 ]
Ugo Matrangolo commented on DERBY-2539:
---------------------------------------
Absolutely no objections.
The old code ignored the exception with an empty catch() block. I filled it but the simplest solution is to let the code try the exception as you noticed.
Thank you for your attention,
Ugo.
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo closed DERBY-2539.
---------------------------------
Resolution: Fixed
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2539:
----------------------------------
Attachment: DERBY-2539_stat_200407.txt
DERBY-2539_diff_200407.txt
Conversion of the timestampArith.java test. Please review. Thanx.
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_stat_200407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491034 ]
Kathey Marsden commented on DERBY-2539:
---------------------------------------
committed patch DERBY-2539_diff_210407.txt
Date: Mon Apr 23 12:37:23 2007
New Revision: 531571
URL: http://svn.apache.org/viewvc?view=rev&rev=531571
Log:
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2539:
----------------------------------
Derby Info: [Patch Available]
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_stat_200407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490472 ]
Kathey Marsden commented on DERBY-2539:
---------------------------------------
This issue is marked resolved, but I don't see that the patch has been committed yet.
Does the patch still need to be committed for this issue? If so it should probably be reopenned until the patch has been committed.
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt, DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489827 ]
Kathey Marsden commented on DERBY-2539:
---------------------------------------
Thanks Ugo for the patch. I only have two small comments.
1) in runTest instead of try/catch blocks and failing on exception, you can just have the method throw the exception.
2) When you make the patch please do it from the top of the code tree, so your patch starts with java/testing/org/...
instead of org/...
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_stat_200407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2539) convert lang/timestampArith.java to
JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2539:
----------------------------------
Derby Info: (was: [Patch Available])
> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
> Key: DERBY-2539
> URL: https://issues.apache.org/jira/browse/DERBY-2539
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_stat_200407.txt
>
>
> convert lang/timestampArith.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.