[GitHub] Tresdon commented on issue #4725: Add "Published" feature to dashboards

[GitBox <gi...@apache.org>]

Tresdon commented on issue #4725: Add "Published" feature to dashboards
URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-449490443
 
 
   Hello all, sorry for such a tardy follow-up on this but I've updated the design of this feature as we've discussed. The concerns I kept in mind are:
   ~ The weight of the action should be reflected in the prominence of the indicator / toggle
   ~ Changing the status shouldn't be buried in a drop-down
   ~ It should be clear what a dashboard having a particular status means to new users
   
   The main ways I've alleviated these issues are:
   ~ The indicator / toggle is next to the title making it nigh impossible to miss
   ~ There is no option for publishing in the dropdown, one must use the status toggle (which also always surfaces the tooltip)
   ~ Tooltips are provided which explain what these terms mean and how to interact with it. (For instance prompting clicking the button to toggle it or encouraging users to favorite it if they wish to see it in their list of dashboards)
   
   the mechanics still work the same (admin can see all dashboards, users can see dashboards they've favorited, etc). The description provided by @sylvia-tomiyama a few comments back hits the nail on the head.
   
   The new design moves the toggle between the title of the dashboard and the favorite star – this way the user can do all they need to with the dashboard in regards to publishing in one place:
   
   1. See the status clearly displayed
   2. Toggle the status (if permitted)
   3. Favorite the dashboard if they wish to (due to it being a draft and wanting to access it later) 
   
   ## **For a draft (unpublished) dashboard**
   
   ### _As the owner_
   
   This badge is no longer just a badge but actually a `<button>` tag so that the user can toggle the status. It then says "Published" as you can see in a couple images.
   ![image](https://raw.githubusercontent.com/Tresdon/misc_public/master/images/superset/draft_as_admin.png)
   
   ### _As another_
   
   This badge is not clickable since the user does not have edit rights on the dashboard. It is just a `<div>` tag
   ![image](https://raw.githubusercontent.com/Tresdon/misc_public/master/images/superset/draft_as_gamma.png)
   
   ## **For a published dashboard**
   
   ### _As the owner_
   
   This is a  <button> which will toggle back to being a draft if clicked. Same as above. I didn't get it in the image but it has the tooltip:
   > This dashboard is published. Click to make it a draft.
   
   ![image](https://raw.githubusercontent.com/Tresdon/misc_public/master/images/superset/published_as_admin.png)
   
   ### _As another_
   
   Nothing shows up for this user since it's a published dashboard.
   ![image](https://raw.githubusercontent.com/Tresdon/misc_public/master/images/superset/published_as_gamma.png)
   
   ## To summarize:
   Those with permissions to edit the dashboard will always see a `<button>` which specifies the current state of the dashboard and allows them to toggle it.
   
   Those who are just visiting the dashboard will see a non-clickable (`<div>`) "Draft" badge if it is a draft else they will see nothing.
   
   I think this addresses the main concerns we were discussing but would love to get some feedback from @elibrumbaugh and any other folks who may be relevant so that we might be able to move forward on this.
   
   Hope everyone's holiday season is great!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org