You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2000/12/13 06:41:07 UTC
RE: [PATCH] Fixes for PR#4468 and PR#5997 - Was: Re: FW: mod_proxy/5997: ProxyCache Garbage Collection did not work - I fixed it
They do make sense, and they appear to have been entirely applied
already in 1.3.14 - if you have a current patch to fix a current
issue, please diff it against the most recent tree.
Bill
> -----Original Message-----
> From: William A. Rowe, Jr. [mailto:wrowe@rowe-clan.net]
> Sent: Tuesday, November 21, 2000 1:19 PM
> To: new-httpd@apache.org; 'Dirk-Willem van Gulik';
> Kai-Uwe.Rommel@ARS.de
> Subject: RE: [PATCH] Fixes for PR#4468 and PR#5997 - Was: Re: FW:
> mod_proxy/5997: ProxyCache Garbage Collection did not work -
> I fixed it
>
>
> Thank you for the patch - I will look at it closely...
>
> Footnote, several patches -were- applied to fix GC, and that
> was an aspect of 1) threading, and 2) opening directories.
> These patches are in. Also, a number of write/send transforms
> were applied. I'll look at your patch and see where it now
> fits... we will release a 1.3.15 on short order, since there
> are two critical issues that were introduced in 1.3.13/.14.
>
> Bill
>
> > -----Original Message-----
> > From: Kai-Uwe Rommel [mailto:Kai-Uwe.Rommel@ARS.de]
> > Sent: Tuesday, November 21, 2000 5:52 AM
> > To: Dirk-Willem van Gulik
> > Cc: new-httpd@apache.org
> > Subject: [PATCH] Fixes for PR#4468 and PR#5997 - Was: Re: FW:
> > mod_proxy/5997: ProxyCache Garbage Collection did not work -
> > I fixed it
> >
> >
> >
> > I hope you still remember this issue, see appendend Mail below.
> > Recently you released Apache 1.3.14 - just to let me discover that
> > you STILL did not include the supplied fixes for the two bugs.
> >
> > It seems that your people are simply ignorants and equate OpenSource
> > with "do not take that job seriosly, this is just fun".
> >
> > WILL I EVER SEE THESE FIXES INTEGRATED?????
> >
> > Kai Uwe Rommel
> >
> > --
> > /* Kai Uwe Rommel ARS Computer &
> > Consulting GmbH *
> > * rommel@ars.de (http://www.ars.de) Muenchen,
> > Germany *
> > * rommel@leo.org (http://archiv.leo.org/pub/comp/os/os2
> > maintenance) */
> > ----- Forwarded by Kai-Uwe Rommel/ARS GmbH on 21.11.2000 12:49 -----
> >
> >
> > Kai-Uwe Rommel
> > 16.05.2000 08:23
> >
> >
> > To: Dirk-Willem van Gulik <di...@webweaving.org>
> > cc: new-httpd@apache.org
> > Subject: [PATCH] Fixes for PR#4468 and PR#5997
> > - Was: Re:
> > FW: mod_proxy/5997: Proxy
> > Cache Garbage Collection did not work - I fixed it
> >
> >
> > Dirk-Willem van Gulik <di...@webweaving.org> wrote on
> > 16.5.2000 01:13:02:
> > >
> > > Kai-Uwe,
> > >
> > > Sorry for not getting on the ball quicker... Could you
> just post the
> > patch
> > > to either me or the new-httpd mailing list ? That is the
> > surest way to
> > get
> > > things incorperated.. you reach the developers directly.
> (We are not
> > very
> > > good at monitoring the bug's db).
> > >
> > > And I'd like to see your PR#4468 as well, could you post
> > that too in a
> > > separate mail. Just put [PATCH] in the Subject and people
> > will surely
> > notice!
> > >
> > > Dw
> >
> > Thanks for the reply. I will attach the two fixes (one
> single context
> > diff, since both are bugs of the proxy module) to this message.
> >
> > a) Make the proxy cache garbage collection work. The code is now
> > changed so that it works on WIN32 similar to the already existing
> > OS/2 code branch. The old code caused the loop to exit on an
> > error (trying to read() a directory under Win32 does not work)
> > and thus never came to delete anything at all so the cache grew
> > and grew ...
> >
> > b) SSL tunneling through the proxy now works on Win32.
> Win32 requires
> > to use send() and recv() on sockets instead of read()
> and write().
> >
> > > On Thu, 11 May 2000, Marc Slemko wrote:
> > >
> > > > On Thu, 11 May 2000, jon * wrote:
> > > >
> > > > > This one is cute. :-)
> > > >
> > > > It is cute, true.
> >
> > Thanks for calling me "cute" without ever having seen me ... :-)
> >
> > Anyway: as I really appreciate it using free software (and
> have worked
> > on free software myself as well - RCS for the PC), I know how
> > important
> > it is to process external fixes. The programmers themselves
> > rarely have
> > time enough to fix everything themselves.
> >
> > And I hate it to waste time again with every Apache release applying
> > the same fix again and recompiling because the Apache team is unable
> > to integrate it in the first place.
> >
> > > > However, it does bring up the bigger issue of just how
> > bug reports are
> > > > dealt with. And how many reports with fixes in them are
> > ignored. Now,
> > > > I'm not saying that what this person claims as a fix
> > actually fixes
> > > > anything or is usable. But the issue in general is a
> > real one. And I
> > > > don't know what can be done. Aside from hire some person
> > whose job
> > > > includes dealing with bug reports, both wanker reports
> > and non-wanker
> > > > reports.
> > > >
> > > > Oh, and since you are here... what about the recent PR
> saying that
> > > > http://java.apache.org/jserv/sendbug.html doesn't work?
> > And while we
> > do
> > > > have categories in gnats for a couple of projects, do
> > people actually
> > do
> > > > anything useful with them or are they just voids?
> > > >
> > > > I would tell you how few people subscribe to the bugdb
> > list, how few
> > > > people cared when it was broken for months and months,
> etc. but I
> > can't
> > > > get a count of how many people are subscribed any more...
> > so I'll say
> > 4.
> > > >
> > > >
> > > > >
> > > > > -jon
> > > > >
> > > > > --
> > > > > Java Servlet Based - Open Source | Collab.Net
> > > > > Bug/Issue Tracking System | now hiring
> > smart people
> > > > > <http://scarab.tigris.org/> |
> > <http://Collab.Net/jobs/>
> > > > >
> > > > > ----------
> > > > > From: "Kai-Uwe Rommel" <Ro...@ARS.de>
> > > > > Date: Thu, 11 May 2000 12:57:24 +0200
> > > > > To: submit@bugz.apache.org, apache-bugdb@apache.org,
> > postmaster@apache.org
> > > > > Cc: apache@apache.org
> > > > > Subject: Re: mod_proxy/5997: Proxy Cache Garbage
> > Collection did not
> > work - I
> > > > > fixed it
> > > > >
> > > > >
> > > > >
> > > > > WOULD YOU PLEASE CARE TO RESPOND!!!
> > > > >
> > > > > I WILL NOT ACCEPT THAT YOU REFUSE ME TO FIX/SUPPORT A
> > FREE PRODUCT.
> > > > >
> > > > > Kai-Uwe Rommel/ARS GmbH wrote on 1.5.2000 15:08:54:
> > > > > >
> > > > > >
> > > > > > submit@bugz.apache.org wrote on 17.4.2000 11:20:00:
> > > > > > >
> > > > > > > Thank you very much for your problem report.
> > > > > > > It has the internal identification `mod_proxy/5997'.
> > > > > > > The individual assigned to look at your
> > > > > > > report is: apache.
> > > > > > >
> > > > > > > >Category: mod_proxy
> > > > > > > >Responsible: apache
> > > > > > > >Synopsis: Proxy Cache Garbage Collection did
> > not work - I
> > fixed
> > > > > it
> > > > > > > >Arrival-Date: Mon Apr 17 02:20:00 PDT 2000
> > > > > >
> > > > > > Would someone please care to respond? Since I did not
> > only report
> > > > > > a bug but also FIXED it and offering you the fix, I
> > would at least
> > > > > > expect you to request that fix from me.
> > > > > >
> > > > > > What poor kind of service the Apache team has become ...
> > > > >
> > > > > Kai Uwe Rommel
> > > > >
> > > > > --
> > > > > /* Kai Uwe Rommel ARS Computer &
> > Consulting GmbH *
> > > > > * rommel@ars.de (http://www.ars.de)
> > Muenchen, Germany *
> > > > > * rommel@leo.org (http://www.leo.org/pub/comp/os/os2
> > maintenance) */
> > > > >
> > > > >
> > > >
> >
> >
> >
> > Kai Uwe Rommel
> >
> > --
> > /* Kai Uwe Rommel ARS Computer & Consulting GmbH *
> > * rommel@ars.de (http://www.ars.de) Muenchen, Germany *
> > * rommel@leo.org (http://www.leo.org/pub/comp/os/os2
> maintenance) */
> >
> >
> >
> >
> >
> >
> > (See attached file: apache_1312_win32.diff)
>