impala git commit: IMPALA-7008: Rewrite query to make it not return 100M rows

[ta...@apache.org]

Repository: impala
Updated Branches:
  refs/heads/2.x c2186c752 -> e10abed2c


IMPALA-7008: Rewrite query to make it not return 100M rows

One query in spilling.test is expected to fail. When it does not fail,
it returned 100M rows, which would then cause the Python test code to
consume memory until it gets OOM-killed by the kernel.

To fix this, we rewrite the query. I tested this locally to make sure
that the query still fails as expected on HDFS.

Change-Id: I31956d3092a7e69b979f631df3a6dfda14ebe140
Reviewed-on: http://gerrit.cloudera.org:8080/10597
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/e10abed2
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/e10abed2
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/e10abed2

Branch: refs/heads/2.x
Commit: e10abed2c6b468b91b01f466526d203701afbfc3
Parents: c2186c7
Author: Lars Volker <lv...@cloudera.com>
Authored: Thu May 31 17:34:02 2018 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Jun 5 02:10:18 2018 +0000

----------------------------------------------------------------------
 .../workloads/functional-query/queries/QueryTest/spilling.test    | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/e10abed2/testdata/workloads/functional-query/queries/QueryTest/spilling.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/spilling.test b/testdata/workloads/functional-query/queries/QueryTest/spilling.test
index 13f863b..835dbdc 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/spilling.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/spilling.test
@@ -297,9 +297,12 @@ row_regex: .*SpilledPartitions: .* \([1-9][0-9]*\)
 ---- QUERY
 # Test spilling join with many duplicates in join key. We don't expect this to succeed
 # with a memory constraint: see IMPALA-4857.
+# The additional "order by" and "limit" clauses make sure that a successful
+# query does not too much data to the client.
 set buffer_pool_limit=167m;
 select *
 from lineitem l1 join lineitem l2 on l1.l_linenumber = l2.l_linenumber
+order by l1.l_orderkey desc, l1.l_linenumber desc limit 10
 ---- CATCH
 Repartitioning did not reduce the size of a spilled partition
 ====