[jira] [Commented] (CB-5805) Multiple File transfer abort problem

["Andrew Grieve (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873432#comment-13873432 ] 

Andrew Grieve commented on CB-5805:
-----------------------------------

Sounds like you have a good grasp on the issue. Would you be willing to create a pull request / patch with a fix for it?

> Multiple File transfer abort problem
> ------------------------------------
>
>                 Key: CB-5805
>                 URL: https://issues.apache.org/jira/browse/CB-5805
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: 3.3.0
>         Environment: Android
>            Reporter: hariharan
>              Labels: FileTransfer
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a threading issue when multiple files are getting downloaded and when we abort one of the download. Way to reproduce the issue.
> - Give a request to download a file1.
> - Call abort() for that file download. 
> - On callback of the abort start downloading file2. 
> - now abort file2. 
> Current behavior - the abort() function returns the callback but actual thread but the download still happens in the background. 
> Expected - The download should not continue when aborting the second file.
> Code details.
> abort() function actually removes the requests form activeRequests.
> but finally() block of download tries to remove the requests from activeRequests again causing it to fail.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)