[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7555: API, Core: Expose file and data sequence numbers through ContentFile

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1187739862


##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -113,6 +113,16 @@ default Integer sortOrderId() {
     return null;
   }
 
+  /** Returns the data sequence number of the snapshot in which the file should be applied. */
+  default Long dataSequenceNumber() {

Review Comment:
   based on the spec, we should call this `sequenceNumber` instead of `dataSequenceNumber`? Although I know `dataSequenceNumber` is probably more clear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org