You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/01 03:34:35 UTC

[GitHub] [incubator-celeborn] nafiyAix opened a new pull request, #1037: [CELEBORN-95][REFACTOR]Rename CLIENT_RPC_ASK_TIMEOUT to HA_CLIENT_RPC_ASK_TIMEOUT

nafiyAix opened a new pull request, #1037:
URL: https://github.com/apache/incubator-celeborn/pull/1037

   ### What changes were proposed in this pull request?
   Rename CLIENT_RPC_ASK_TIMEOUT to HA_CLIENT_RPC_ASK_TIMEOUT, and move its category from `client` module to `network` module.
   
   ### Why are the changes needed?
   Because current name is a bit easily confused with ShuffleClient related config, and its categories is `client`, but maybe `network` may better. 
   
   ### What are the items that need reviewer attention?
   `celeborn.client.maxRetries` also has same problem
   
   ### Related issues.
   
   
   ### Related pull requests.
   
   
   ### How was this patch tested?
   
   
   /cc @pan3793 @AngersZhuuuu 
   
   /assign @main-reviewer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1037: [CELEBORN-95][REFACTOR]Rename CLIENT_RPC_ASK_TIMEOUT to HA_CLIENT_RPC_ASK_TIMEOUT

Posted by GitBox <gi...@apache.org>.

AngersZhuuuu merged PR #1037:
URL: https://github.com/apache/incubator-celeborn/pull/1037


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org