[GitHub] [cloudstack] ezntt commented on pull request #7234: Enable CPU cap in VRs if the offering has a CPU cap limitation

["ezntt (via GitHub)" <gi...@apache.org>]

ezntt commented on PR #7234:
URL: https://github.com/apache/cloudstack/pull/7234#issuecomment-1444107078

   Sure, @DaanHoogland, I approve the feature based on my testing, which was carried out using a similar approach to the PR owner.
   
   I tested the change by creating a VR and verifying its dumpxml to confirm that cpushares tag was set correctly. Specifically, I confirmed that the tag:
   ```
   <cputune>
       <shares>500</shares> 
   </cputune>
   ```
   were properly defined, which confirmed that the change was successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org