You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/07 17:40:44 UTC
[GitHub] [spark] huaxingao opened a new pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
huaxingao opened a new pull request #33927:
URL: https://github.com/apache/spark/pull/33927
### What changes were proposed in this pull request?
Currently, we have `FieldReference` for aggregate column type, should be `NamedReference` instead
### Why are the changes needed?
Fix problem
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914669746
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143057/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914568650
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47560/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914962468
Thanks all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33927:
URL: https://github.com/apache/spark/pull/33927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914499060
**[Test build #143057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143057/testReport)** for PR 33927 at commit [`2b0e8dd`](https://github.com/apache/spark/commit/2b0e8dd27ead65030844ff7fe532ba91ea9120ac).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914668989
**[Test build #143057 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143057/testReport)** for PR 33927 at commit [`2b0e8dd`](https://github.com/apache/spark/commit/2b0e8dd27ead65030844ff7fe532ba91ea9120ac).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914633976
cc @cloud-fan @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914499060
**[Test build #143057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143057/testReport)** for PR 33927 at commit [`2b0e8dd`](https://github.com/apache/spark/commit/2b0e8dd27ead65030844ff7fe532ba91ea9120ac).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914568691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47560/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914863184
"Fix problem" sounds too general. :)
@huaxingao Maybe add a few words there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914528441
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47560/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914568691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47560/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914866940
> "Fix problem" sounds too general. :)
yea, should be something like `FieldReference is a private class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914945033
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33927: [SPARK-34952][SQL][FOLLOWUP] Change column type to be NamedReference
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33927:
URL: https://github.com/apache/spark/pull/33927#issuecomment-914669746
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143057/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org