[GitHub] [johnzon] jgallimore commented on a change in pull request #70: JOHNZON-325 see if we can get something that makes everyone happy

[GitBox <gi...@apache.org>]

jgallimore commented on a change in pull request #70:
URL: https://github.com/apache/johnzon/pull/70#discussion_r534091752



##########
File path: johnzon-core/src/main/java/org/apache/johnzon/core/JsonProviderImpl.java
##########
@@ -53,6 +53,12 @@
 import javax.json.stream.JsonParserFactory;
 
 public class JsonProviderImpl extends JsonProvider implements Serializable {
+
+    /**
+     * This makes Johnzon to be compliant with spec, essentially regarding the JSON Pointer /-

Review comment:
       Given that the TCK is open, I'd suggest referencing the specific test case here. Not so much for a javadoc point of view, but more to track the history. The JSR (as far as I can see) doesn't have any spec text at all, so a developer going looking for it, will at best arrive at the RFC.
   
   The setting is necessary for Johnzon to be compliant with JSR-374 / Jakarta JSON Processing (https://github.com/eclipse-ee4j/jsonp/), which specifies the "/-" reference points to the index _after_ the last element in the array: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jsonp...<whichever test>




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org