You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/04/17 19:17:25 UTC
Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1791
https://issues.apache.org/jira/browse/OOZIE-1791
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1791
WIP, just to show design, need to add test case and proper error handling, etc..
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
client/src/main/java/org/apache/oozie/client/Job.java 8533165
client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleActionIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
core/src/main/java/org/apache/oozie/command/coord/CoordIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
Diff: https://reviews.apache.org/r/20451/diff/
Testing
-------
Not yet
Thanks,
Ryota Egashira
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/#review41062
-----------------------------------------------------------
We should disallow coord action rerun for ignored jobs.
- Purshotam Shah
On April 22, 2014, 12:26 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20451/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 12:26 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1791
> https://issues.apache.org/jira/browse/OOZIE-1791
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1791
>
> WIP, just to show design, need to add test case and proper error handling, etc..
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
> client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
> client/src/main/java/org/apache/oozie/client/Job.java 8533165
> client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
> core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
> core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
> core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
> core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
> core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
> core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
> core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
> core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
> core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java ea2ca27
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
> docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
> docs/src/site/twiki/WebServicesAPI.twiki 351699d
>
> Diff: https://reviews.apache.org/r/20451/diff/
>
>
> Testing
> -------
>
> Not yet
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/#review41022
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On April 22, 2014, 12:26 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20451/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 12:26 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1791
> https://issues.apache.org/jira/browse/OOZIE-1791
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1791
>
> WIP, just to show design, need to add test case and proper error handling, etc..
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
> client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
> client/src/main/java/org/apache/oozie/client/Job.java 8533165
> client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
> core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
> core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
> core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
> core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
> core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
> core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
> core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
> core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
> core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java ea2ca27
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
> docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
> docs/src/site/twiki/WebServicesAPI.twiki 351699d
>
> Diff: https://reviews.apache.org/r/20451/diff/
>
>
> Testing
> -------
>
> Not yet
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/
-----------------------------------------------------------
(Updated April 22, 2014, 12:26 a.m.)
Review request for oozie.
Changes
-------
revised based on rohini's comments
Bugs: OOZIE-1791
https://issues.apache.org/jira/browse/OOZIE-1791
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1791
WIP, just to show design, need to add test case and proper error handling, etc..
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
client/src/main/java/org/apache/oozie/client/Job.java 8533165
client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java ea2ca27
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
docs/src/site/twiki/WebServicesAPI.twiki 351699d
Diff: https://reviews.apache.org/r/20451/diff/
Testing
-------
Not yet
Thanks,
Ryota Egashira
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/#review40974
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/20451/#comment74307>
"-" + ACTION_OPTION " values is empty"
Remove scope from the message. It is only used internally and may be confusing to user.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/20451/#comment74308>
Why is ignore required?
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/20451/#comment74309>
Shouldn't ignore be returning a list of status messages instead of coordinator actions?
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/20451/#comment74310>
ignored Coordinator Actions(s)
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java
<https://reviews.apache.org/r/20451/#comment74312>
numbers(s)
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java
<https://reviews.apache.org/r/20451/#comment74313>
You also need to check for action.getPending = 0. KILLED coordaction pending will have 1 till the workflows are killed. So let's not allow ignore before pending becomes 0.
Lets not allow killing a suspended action as pending of supended is not reset until resumed. Let user kill it and then ignore it.
Allow ignoring TIMEDOUT actions
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/20451/#comment74314>
Only allow FAILED, KILLED to be IGNORED and only when pending is 0.
core/src/main/java/org/apache/oozie/service/RecoveryService.java
<https://reviews.apache.org/r/20451/#comment74315>
Unused import
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java
<https://reviews.apache.org/r/20451/#comment74317>
formatting
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/20451/#comment74318>
changes
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/20451/#comment74319>
Remove this line. Bundle actions are internal and not exposed to user.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/20451/#comment74320>
Please change all references of bundle action to "coordinator job in a bundle"
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/20451/#comment74321>
changes coordinator action(s)
- Rohini Palaniswamy
On April 21, 2014, 9:29 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20451/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:29 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1791
> https://issues.apache.org/jira/browse/OOZIE-1791
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1791
>
> WIP, just to show design, need to add test case and proper error handling, etc..
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
> client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
> client/src/main/java/org/apache/oozie/client/Job.java 8533165
> client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
> core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
> core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
> core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
> core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
> core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
> core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
> core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
> core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
> core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
> core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
> docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
> docs/src/site/twiki/WebServicesAPI.twiki 351699d
>
> Diff: https://reviews.apache.org/r/20451/diff/
>
>
> Testing
> -------
>
> Not yet
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/
-----------------------------------------------------------
(Updated April 21, 2014, 9:29 p.m.)
Review request for oozie.
Changes
-------
-fixed some of remaining comments.
-fixed bugs found in e2e test, now works fine.
-changed TestCoordActionsIgnoreXCommand
Bugs: OOZIE-1791
https://issues.apache.org/jira/browse/OOZIE-1791
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1791
WIP, just to show design, need to add test case and proper error handling, etc..
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
client/src/main/java/org/apache/oozie/client/Job.java 8533165
client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
docs/src/site/twiki/WebServicesAPI.twiki 351699d
Diff: https://reviews.apache.org/r/20451/diff/
Testing
-------
Not yet
Thanks,
Ryota Egashira
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/
-----------------------------------------------------------
(Updated April 21, 2014, 5:32 p.m.)
Review request for oozie.
Changes
-------
current version, modified based on comments (some pending)
remaining item,
- fix bugs found in e2e test
- add couple cases in TestCoordActionsIgnoreXCommand
Bugs: OOZIE-1791
https://issues.apache.org/jira/browse/OOZIE-1791
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1791
WIP, just to show design, need to add test case and proper error handling, etc..
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
client/src/main/java/org/apache/oozie/client/Job.java 8533165
client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
docs/src/site/twiki/WebServicesAPI.twiki 351699d
Diff: https://reviews.apache.org/r/20451/diff/
Testing
-------
Not yet
Thanks,
Ryota Egashira
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On April 18, 2014, 6:44 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/BundleActionBean.java, lines 53-55
> > <https://reviews.apache.org/r/20451/diff/2/?file=562213#file562213line53>
> >
> > Can you rename them appropriately?
> >
> > GET_*_STATUS_UNIGNORED
> >
> > GET_BUNDLE_ACTIONS_FOR_BUNDLE is used by almost all bundle commands. Can we add a note in documentation to change endtime/pausetime of bundle that ignored coordinators will not be changed when setting endtime/pausetime. Also suspend, resume, kill will not affect them.
generally we can solve naming convention in different jira.
GET_BUNDLE_ACTION_STATUS_PENDING_FOR_BUNDLE changed to GET_BUNDLE_UNIGNORED_ACTION_STATUS_PENDING_FOR_BUNDLE, to avoid status show up twice.
(_STATUS_PENDING mean fetch these two columns, this is convention used in other places, can be fixed later in one shot)
> On April 18, 2014, 6:44 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 221
> > <https://reviews.apache.org/r/20451/diff/2/?file=562216#file562216line221>
> >
> > CoordActionIgnoreXCommand - consistent naming
use the same convention with CoordActionsKillXCommand,
alternative is CoordIgnoreXCommand, but CoordActionsIgnore is more specific, (I think CoordRerunXCommand should be also changed to CoordActionsRerun..)
> On April 18, 2014, 6:44 p.m., Rohini Palaniswamy wrote:
> > docs/src/site/twiki/DG_CommandLineTool.twiki, line 647
> > <https://reviews.apache.org/r/20451/diff/2/?file=562230#file562230line647>
> >
> > PAUSED ?
wondering if we should support PAUSED->SUSPENDED? no strong use case. anyway user can kill/suspend first to ignore it.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/#review40782
-----------------------------------------------------------
On April 21, 2014, 5:32 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20451/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 5:32 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1791
> https://issues.apache.org/jira/browse/OOZIE-1791
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1791
>
> WIP, just to show design, need to add test case and proper error handling, etc..
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
> client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
> client/src/main/java/org/apache/oozie/client/Job.java 8533165
> client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 4091808
> core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
> core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
> core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1a11765
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 58afeac
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
> core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 3ab3273
> core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 90e205a
> core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
> core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
> core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 9c628ab
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusJPAExecutor.java 2cee5f0
> core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
> core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
> core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 443ab6d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 2d26599
> core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5aa9e6f
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 76c7a29
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 225d48e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 498ac0d
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 7d6542a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java 3ae4d6c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java aa5442c
> docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
> docs/src/site/twiki/WebServicesAPI.twiki 351699d
>
> Diff: https://reviews.apache.org/r/20451/diff/
>
>
> Testing
> -------
>
> Not yet
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/#review40782
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/20451/#comment73923>
isn't ignore a switch? What will be the getOptionValue() of it?
Please pass range type and scope, so that we can add -date option in future in addition to -action similar to other commands.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/20451/#comment73924>
Accidental change. To be reverted/
core/src/main/java/org/apache/oozie/BundleActionBean.java
<https://reviews.apache.org/r/20451/#comment73946>
Can you rename them appropriately?
GET_*_STATUS_UNIGNORED
GET_BUNDLE_ACTIONS_FOR_BUNDLE is used by almost all bundle commands. Can we add a note in documentation to change endtime/pausetime of bundle that ignored coordinators will not be changed when setting endtime/pausetime. Also suspend, resume, kill will not affect them.
core/src/main/java/org/apache/oozie/BundleEngine.java
<https://reviews.apache.org/r/20451/#comment73925>
To be removed
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/20451/#comment73947>
Can be avoided and handled in StatusTransitService or change name of the query to GET_COORD_ACTIONS_STATUS_UNIGNORED.
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/20451/#comment73926>
CoordActionIgnoreXCommand - consistent naming
core/src/main/java/org/apache/oozie/ErrorCode.java
<https://reviews.apache.org/r/20451/#comment73927>
run
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java
<https://reviews.apache.org/r/20451/#comment73951>
To be removed. Please do not add non-Javadoc comments. If possible remove existing ones in your patches.
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java
<https://reviews.apache.org/r/20451/#comment73953>
Log messages should be info.
We need to propagate status back to user. Please make it a synchronous call to command in the JobServlet and return a String like CoordChangeXCommand.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/20451/#comment73937>
The conditions should have || inside and a single ! outside.
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/20451/#comment73933>
Just implement in v2. Not in v1.
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/20451/#comment73932>
else ?
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/20451/#comment73930>
PAUSED ?
docs/src/site/twiki/WebServicesAPI.twiki
<https://reviews.apache.org/r/20451/#comment73928>
type=action, so that we can have date in the future
- Rohini Palaniswamy
On April 18, 2014, 4:43 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20451/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 4:43 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1791
> https://issues.apache.org/jira/browse/OOZIE-1791
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1791
>
> WIP, just to show design, need to add test case and proper error handling, etc..
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
> client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
> client/src/main/java/org/apache/oozie/client/Job.java 8533165
> client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5eb134b
> core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
> core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
> core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
> core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
> core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
> core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
> docs/src/site/twiki/WebServicesAPI.twiki 351699d
>
> Diff: https://reviews.apache.org/r/20451/diff/
>
>
> Testing
> -------
>
> Not yet
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/
-----------------------------------------------------------
(Updated April 18, 2014, 4:43 p.m.)
Review request for oozie.
Changes
-------
current version modified based on feedback. still WIP, now adding test case and doing e2e test.
Bugs: OOZIE-1791
https://issues.apache.org/jira/browse/OOZIE-1791
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1791
WIP, just to show design, need to add test case and proper error handling, etc..
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd
client/src/main/java/org/apache/oozie/client/Job.java 8533165
client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5eb134b
core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a
core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 2e5f6b4
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 0db2dad
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942
core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
core/src/main/java/org/apache/oozie/service/StatusTransitService.java e093c7d
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71
docs/src/site/twiki/WebServicesAPI.twiki 351699d
Diff: https://reviews.apache.org/r/20451/diff/
Testing
-------
Not yet
Thanks,
Ryota Egashira
Re: Review Request 20451: OOZIE-1791 add IGNORED status to Coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20451/
-----------------------------------------------------------
(Updated April 17, 2014, 5:17 p.m.)
Review request for oozie.
Bugs: OOZIE-1791
https://issues.apache.org/jira/browse/OOZIE-1791
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1791
WIP, just to show design, need to add test case and proper error handling, etc..
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0
client/src/main/java/org/apache/oozie/client/Job.java 8533165
client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleActionIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java 2ddfbdb
core/src/main/java/org/apache/oozie/command/coord/CoordIgnoreXCommand.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
Diff: https://reviews.apache.org/r/20451/diff/
Testing
-------
Not yet
Thanks,
Ryota Egashira