You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/04 06:18:43 UTC
[GitHub] [submarine] atosystem opened a new pull request #817: Submarine 1095. Incorporate Click CLI in SDK
atosystem opened a new pull request #817:
URL: https://github.com/apache/submarine/pull/817
### What is this PR for?
Introduce click module to submarine SDK.
Allowing the followings commands
```
submarine sandbox start # create submarine sandbox
submarine sandbox start --version 0.6.0
submarine sandbox delete # delete submarine sandbox
submarine get experiment <id>
submarine get notebook <id>
submarine get environment <id>
submarine list experiment
submarine list notebook
submarine list environment
submarine delete experiment <id>
submarine delete notebook <id>
submarine delete environment <id>
```
### What type of PR is it?
[Feature]
### Todos
* [ ] - Connect backend API
* [ ] - Write docs for CLI
### What is the Jira issue?
[SUBMARINE-1095](https://issues.apache.org/jira/browse/SUBMARINE-1095)
### How should this be tested?
python unit tests are implemented for command line testing
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #817: Submarine 1095. Incorporate Click CLI in SDK
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #817:
URL: https://github.com/apache/submarine/pull/817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #817: Submarine 1095. Incorporate Click CLI in SDK
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on a change in pull request #817:
URL: https://github.com/apache/submarine/pull/817#discussion_r763555656
##########
File path: submarine-sdk/pysubmarine/submarine/cli/__init__.py
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# coding: utf-8
+
+# flake8: noqa
+"""
+ Submarine Command Line Interface
+
+ The Submarine CLI allows you to interact with submarine backend via command line.
+
+ The version of the OpenAPI document: 0.7.0-SNAPSHOT
+ Contact: dev@submarine.apache.org
+ Generated by: https://openapi-generator.tech
+"""
+
+from __future__ import absolute_import
+
+# # import apis into sdk package
+# from submarine.experiment.api.experiment_api import ExperimentApi
+
+# # import ApiClient
+# from submarine.experiment.api_client import ApiClient
+# from submarine.experiment.configuration import Configuration
+# from submarine.experiment.exceptions import (
+# ApiException,
+# ApiKeyError,
+# ApiTypeError,
+# ApiValueError,
+# OpenApiException,
+# )
+
+# # import models into sdk package
+# from submarine.experiment.models.code_spec import CodeSpec
+# from submarine.experiment.models.environment_spec import EnvironmentSpec
+# from submarine.experiment.models.experiment_meta import ExperimentMeta
+# from submarine.experiment.models.experiment_spec import ExperimentSpec
+# from submarine.experiment.models.experiment_task_spec import ExperimentTaskSpec
+# from submarine.experiment.models.json_response import JsonResponse
+# from submarine.experiment.models.kernel_spec import KernelSpec
Review comment:
Remove these comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] atosystem commented on a change in pull request #817: Submarine 1095. Incorporate Click CLI in SDK
Posted by GitBox <gi...@apache.org>.
atosystem commented on a change in pull request #817:
URL: https://github.com/apache/submarine/pull/817#discussion_r763621395
##########
File path: submarine-sdk/pysubmarine/submarine/cli/__init__.py
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# coding: utf-8
+
+# flake8: noqa
+"""
+ Submarine Command Line Interface
+
+ The Submarine CLI allows you to interact with submarine backend via command line.
+
+ The version of the OpenAPI document: 0.7.0-SNAPSHOT
+ Contact: dev@submarine.apache.org
+ Generated by: https://openapi-generator.tech
+"""
+
+from __future__ import absolute_import
+
+# # import apis into sdk package
+# from submarine.experiment.api.experiment_api import ExperimentApi
+
+# # import ApiClient
+# from submarine.experiment.api_client import ApiClient
+# from submarine.experiment.configuration import Configuration
+# from submarine.experiment.exceptions import (
+# ApiException,
+# ApiKeyError,
+# ApiTypeError,
+# ApiValueError,
+# OpenApiException,
+# )
+
+# # import models into sdk package
+# from submarine.experiment.models.code_spec import CodeSpec
+# from submarine.experiment.models.environment_spec import EnvironmentSpec
+# from submarine.experiment.models.experiment_meta import ExperimentMeta
+# from submarine.experiment.models.experiment_spec import ExperimentSpec
+# from submarine.experiment.models.experiment_task_spec import ExperimentTaskSpec
+# from submarine.experiment.models.json_response import JsonResponse
+# from submarine.experiment.models.kernel_spec import KernelSpec
Review comment:
OK!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org