You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2018/03/14 22:07:43 UTC
Re: Review Request 65769: Remove unused module in RecoveryTool,
move TaskTestUtil to test folder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65769/#review199219
-----------------------------------------------------------
bump
- Jordan Ly
On Feb. 23, 2018, 6:04 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65769/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 6:04 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removing an unused `TierModule` from `RecoveryTool`.
>
> Additionally, resolved an old TODO and moved `TaskTestUtil` to the test folder. It seems that the old version of JMH could not see test sources but https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 seems to fix that.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 2b61c273860a33472890fc22e06b3c53d2086999
> src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java 7cb4c52bc6e890f48a8bc9fe21c54cea38644808
>
>
> Diff: https://reviews.apache.org/r/65769/diff/1/
>
>
> Testing
> -------
>
> `./gradlew test`
> `./gradlew jmh`
>
> end-to-end tests pass.
>
>
> Thanks,
>
> Jordan Ly
>
>