[GitHub] [airflow] ashb commented on issue #6342: [AIRFLOW-5662] fix incorrect naming for scheduler used slot metric

[GitBox <gi...@apache.org>]

ashb commented on issue #6342: [AIRFLOW-5662] fix incorrect naming for scheduler used slot metric
URL: https://github.com/apache/airflow/pull/6342#issuecomment-547130770
 
 
   What do you think of making slot_stats "caching" like this? Then slot_stats could also become `_load_slot_stats` and then the only change in SchedulerJob is to add the new metric, keeping all the details inside Pool class.
   
   ```python
       @provide_session
       def slots_stats(self, session) -> Dict:
           if self._slot_stats:
               return self._slot_stats
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services