You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2009/04/09 10:45:13 UTC
[jira] Created: (LUCENE-1592) fix or deprecate TermsEnum.seek
fix or deprecate TermsEnum.seek
-------------------------------
Key: LUCENE-1592
URL: https://issues.apache.org/jira/browse/LUCENE-1592
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Reporter: Michael McCandless
Priority: Minor
Fix For: 2.9
This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
And, here for historical context:
http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1592:
---------------------------------------
Fix Version/s: 2.9
Assignee: Uwe Schindler
OK moving back to 2.9 & assigning to you Uwe!
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 2.9
>
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-1592.
-----------------------------------
Resolution: Fixed
Committed revision: 783747
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 2.9
>
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1592:
---------------------------------------
Fix Version/s: (was: 2.9)
Moving out.
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718257#action_12718257 ]
Michael McCandless commented on LUCENE-1592:
--------------------------------------------
OK, excellent -- can you commit that?
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699696#action_12699696 ]
Mark Miller commented on LUCENE-1592:
-------------------------------------
I made a quick update to the javadoc so its a bit less misleading, but still needs to be resolved in a stronger manner, al la this issue.
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718237#action_12718237 ]
Uwe Schindler commented on LUCENE-1592:
---------------------------------------
I think deprecation is to do now (before 3.0), so why move this out?
I looked into the source code in trunk, this method is used nowhere, deprecating it should be no problem:
{code}
@deprecated Use {@link IndexReader#terms(Term)} to
create a new TermEnum. This method is not performant.
{code}
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718357#action_12718357 ]
Uwe Schindler commented on LUCENE-1592:
---------------------------------------
I will do this and close this issue, it is better to just deprecate and do not direct users to this method, that is not used (there is not even a test for it) and slow.
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1592:
----------------------------------
Summary: fix or deprecate TermsEnum.skipTo (was: fix or deprecate TermsEnum.seek)
> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
> Key: LUCENE-1592
> URL: https://issues.apache.org/jira/browse/LUCENE-1592
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple linear scan implemented in the TermsEnum base class since none of the concrete impls override it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with a strong warning about its performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context:
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org