You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/06/08 06:02:03 UTC
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
GitHub user jongyoul opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/974
ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter's sql completer into JDBC Interpreter
### What is this PR for?
Supporting Sql completer into JDBC Interpreter which is merged by the function of Postgresql Interpreter. And this is the first step to merge Postgresql into generic JDBC Interpreter
### What type of PR is it?
[Improvement]
### Todos
* [x] - Adopted the function of auto completion
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-614
### How should this be tested?
### Screenshots (if appropriate)
<img width="1054" alt="screen shot 2016-06-08 at 3 00 54 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884224/e241f6b4-2d89-11e6-9746-8c8951ef6708.png">
<img width="474" alt="screen shot 2016-06-08 at 2 45 50 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884229/e7993e24-2d89-11e6-9f5b-018e6eac7f6a.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/incubator-zeppelin ZEPPELIN-614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #974
----
commit 6491cba0d319a7f520fae10c820a9d233d3e593c
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:50:18Z
Added auto completion from PostgresqlInterpreter
commit e49f73c3b03310351ba525d956d1c10de0185cf3
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:54:54Z
Updated original documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/974
ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter's sql completer into JDBC Interpreter
### What is this PR for?
Supporting Sql completer into JDBC Interpreter which is merged by the function of Postgresql Interpreter. And this is the first step to merge Postgresql into generic JDBC Interpreter
### What type of PR is it?
[Improvement]
### Todos
* [x] - Adopted the function of auto completion
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-614
### How should this be tested?
### Screenshots (if appropriate)
<img width="1054" alt="screen shot 2016-06-08 at 3 00 54 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884224/e241f6b4-2d89-11e6-9746-8c8951ef6708.png">
<img width="474" alt="screen shot 2016-06-08 at 2 45 50 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884229/e7993e24-2d89-11e6-9f5b-018e6eac7f6a.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/incubator-zeppelin ZEPPELIN-614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #974
----
commit 6491cba0d319a7f520fae10c820a9d233d3e593c
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:50:18Z
Added auto completion from PostgresqlInterpreter
commit e49f73c3b03310351ba525d956d1c10de0185cf3
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:54:54Z
Updated original documentation
commit d4823957bc784ede3d926eb844bcecabba4dbbd5
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-09T13:58:56Z
Fixed typo and coding style
commit 99ce452b68c757c1959b9d4b7983f7d81000256e
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-09T14:13:21Z
Updated license document
commit 998352c4e746c1e97f49487d176aa84d1abf79ce
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-09T14:17:24Z
Fixed old styles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/974
ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter's sql completer into JDBC Interpreter
### What is this PR for?
Supporting Sql completer into JDBC Interpreter which is merged by the function of Postgresql Interpreter. And this is the first step to merge Postgresql into generic JDBC Interpreter
### What type of PR is it?
[Improvement]
### Todos
* [x] - Adopted the function of auto completion
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-614
### How should this be tested?
### Screenshots (if appropriate)
<img width="1054" alt="screen shot 2016-06-08 at 3 00 54 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884224/e241f6b4-2d89-11e6-9746-8c8951ef6708.png">
<img width="474" alt="screen shot 2016-06-08 at 2 45 50 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884229/e7993e24-2d89-11e6-9f5b-018e6eac7f6a.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/incubator-zeppelin ZEPPELIN-614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #974
----
commit 6491cba0d319a7f520fae10c820a9d233d3e593c
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:50:18Z
Added auto completion from PostgresqlInterpreter
commit e49f73c3b03310351ba525d956d1c10de0185cf3
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:54:54Z
Updated original documentation
commit d4823957bc784ede3d926eb844bcecabba4dbbd5
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-09T13:58:56Z
Fixed typo and coding style
commit 99ce452b68c757c1959b9d4b7983f7d81000256e
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-09T14:13:21Z
Updated license document
commit 998352c4e746c1e97f49487d176aa84d1abf79ce
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-09T14:17:24Z
Fixed old styles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpre...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/974
@tzolov Could you please test this PR with Postrgres, HAWQ and so on? I've heard that you are one of the heavy users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpre...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/974
Great work @jongyoul !
Looks good to me except minor things listed above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpre...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/974
npm build error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/974
ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter's sql completer into JDBC Interpreter
### What is this PR for?
Supporting Sql completer into JDBC Interpreter which is merged by the function of Postgresql Interpreter. And this is the first step to merge Postgresql into generic JDBC Interpreter
### What type of PR is it?
[Improvement]
### Todos
* [x] - Adopted the function of auto completion
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-614
### How should this be tested?
### Screenshots (if appropriate)
<img width="1054" alt="screen shot 2016-06-08 at 3 00 54 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884224/e241f6b4-2d89-11e6-9746-8c8951ef6708.png">
<img width="474" alt="screen shot 2016-06-08 at 2 45 50 pm" src="https://cloud.githubusercontent.com/assets/3612566/15884229/e7993e24-2d89-11e6-9f5b-018e6eac7f6a.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/incubator-zeppelin ZEPPELIN-614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #974
----
commit 6491cba0d319a7f520fae10c820a9d233d3e593c
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:50:18Z
Added auto completion from PostgresqlInterpreter
commit e49f73c3b03310351ba525d956d1c10de0185cf3
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-08T05:54:54Z
Updated original documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpre...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/974
@bzz I updated license files. could you please check it again?
https://github.com/apache/incubator-zeppelin/pull/974/commits/99ce452b68c757c1959b9d4b7983f7d81000256e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlI...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---