[jira] [Resolved] (THRIFT-2851) Remove strange public Peek() from Go transports

["Jens Geyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-2851.
--------------------------------
    Resolution: Fixed

After sleeping a night about it, I think you are right. In its current form Peek() is not only next to useless, but more important misleading to the less careful observer. So unless someone comes up with a better implementation, we should throw it out.

Committed.


> Remove strange public Peek() from Go transports
> -----------------------------------------------
>
>                 Key: THRIFT-2851
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2851
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>    Affects Versions: 0.9.2
>            Reporter: Chi Vinh Le
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> I've been seeing this public Peek() function in the GO library for a while, but
> still cannot figure out any sense to it.
> If there are useless, we can remove them right?
> This PR removes the public Peek() from the implemented transports.
> All tests still pass.
> PR: https://github.com/apache/thrift/pull/283



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)