You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/03/16 11:02:51 UTC

[GitHub] [james-project] jeantil commented on pull request #333: JAMES-3518: Method for docker file copy

jeantil commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800163248


   I'm sorry, I don't understand the purpose of this change. 
   
   As it stands all it does is add an **unused** method to DockerContainer, and the description in  JAMES-3518 doesn't help understand why it is desirable to have a new unused method there. If sonar was setup on the project, the checks would definitely not pass for the PR as it stands.
   
   If you need this change as part of a larger change, please include it in that larger PR. This way the PR will offer context on how and why you need this change ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org