You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/04/22 14:14:58 UTC

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24223


Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................

IMPALA-14824: Replace remaining log4j usage with slf4j

Only exception is JvmPauseMonitor where LOG.fatal() is used which
is not included in slf4j. This is ok as the goal is more consistancy
and not to remove log4j dependency.

Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationPolicy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java
M fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java
M fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/FunctionUtils.java
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M fe/src/test/java/org/apache/impala/planner/ParquetBloomFilterTblPropParserTest.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
M fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
31 files changed, 93 insertions(+), 62 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24223/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24223/3/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
File fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java:

http://gerrit.cloudera.org:8080/#/c/24223/3/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java@357
PS3, Line 357:     LOG.setAdditivity(false);
> This fails to compile.
oops, fixed in ps4



-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 14:57:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24223

to look at the new patch set (#2).

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................

IMPALA-14824: Replace remaining log4j usage with slf4j

Only exception is JvmPauseMonitor where LOG.fatal() is used which
is not included in slf4j. This is ok as the goal is more consistancy
and not to remove log4j dependency.

Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationPolicy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java
M fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java
M fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/FunctionUtils.java
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M fe/src/test/java/org/apache/impala/planner/ParquetBloomFilterTblPropParserTest.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
M fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
31 files changed, 98 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24223/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2026 23:25:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................

IMPALA-14824: Replace remaining log4j usage with slf4j

Exceptions where log4j only functions are used:
- JvmPauseMonitor: LOG.fatal()
- ImpalaJdbcClient: LOG.addAppender()

These exceptions are ok as the goal is more consistancy
and not to remove log4j dependency.

Generated-by: Claude Sonnet 4.6

Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Reviewed-on: http://gerrit.cloudera.org:8080/24223
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationPolicy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java
M fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java
M fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/FunctionUtils.java
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M fe/src/test/java/org/apache/impala/planner/ParquetBloomFilterTblPropParserTest.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
30 files changed, 95 insertions(+), 60 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 4: Code-Review+1

This looks straight forward to me


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2026 23:22:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24223

to look at the new patch set (#3).

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................

IMPALA-14824: Replace remaining log4j usage with slf4j

Only exception is JvmPauseMonitor where LOG.fatal() is used which
is not included in slf4j. This is ok as the goal is more consistancy
and not to remove log4j dependency.

Generated-by: Claude Sonnet 4.6

Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationPolicy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java
M fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java
M fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/FunctionUtils.java
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M fe/src/test/java/org/apache/impala/planner/ParquetBloomFilterTblPropParserTest.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
M fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
31 files changed, 98 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24223/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22207/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 14:31:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 03:47:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2026 23:25:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24223/3/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
File fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java:

http://gerrit.cloudera.org:8080/#/c/24223/3/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java@357
PS3, Line 357:     LOG.addAppender(consoleAppender);
This fails to compile.



-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 15:28:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22206/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 14:26:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24223

to look at the new patch set (#4).

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................

IMPALA-14824: Replace remaining log4j usage with slf4j

Exceptions where log4j only functions are used:
- JvmPauseMonitor: LOG.fatal()
- ImpalaJdbcClient: LOG.addAppender()

These exceptions are ok as the goal is more consistancy
and not to remove log4j dependency.

Generated-by: Claude Sonnet 4.6

Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationPolicy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java
M fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java
M fe/src/main/java/org/apache/impala/catalog/PrincipalPrivilege.java
M fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfInputHandler.java
M fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/FunctionUtils.java
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
M fe/src/main/java/org/apache/impala/util/JMXJsonUtil.java
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
M fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M fe/src/test/java/org/apache/impala/planner/ParquetBloomFilterTblPropParserTest.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
M fe/src/test/java/org/apache/impala/testutil/TestFileParser.java
30 files changed, 95 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24223/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 1:

(5 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java:

http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@54
PS1, Line 54:   public static final Logger LOG = LoggerFactory.getLogger(CatalogdTableInvalidator.class);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java
File fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java:

http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/catalog/ImpaladTableUsageTracker.java@48
PS1, Line 48:   private static final Logger LOG = LoggerFactory.getLogger(ImpaladTableUsageTracker.class);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java
File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java:

http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@48
PS1, Line 48:   private static final Logger LOG = LoggerFactory.getLogger(HiveGenericJavaFunction.class);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java
File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java:

http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyFunctionExtractor.java@39
PS1, Line 39:   private static final Logger LOG = LoggerFactory.getLogger(HiveLegacyFunctionExtractor.class);
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java
File fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java:

http://gerrit.cloudera.org:8080/#/c/24223/1/fe/src/test/java/org/apache/impala/testutil/EmbeddedMetastoreClientPool.java@39
PS1, Line 39:   private static final Logger LOG = LoggerFactory.getLogger(EmbeddedMetastoreClientPool.class);
line too long (95 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 14:17:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22222/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 15:21:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14824: Replace remaining log4j usage with slf4j

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24223 )

Change subject: IMPALA-14824: Replace remaining log4j usage with slf4j
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13462/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ab02468db13ed6e37cac7b6ab74841317a9e6e
Gerrit-Change-Number: 24223
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2026 23:25:42 +0000
Gerrit-HasComments: No