Re: [PR] [SPARK-54320][UI] Fix Job DAG overlapping [spark]

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #53015:
URL: https://github.com/apache/spark/pull/53015#discussion_r2589115674


##########
core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js:
##########
@@ -295,6 +295,20 @@ function renderDagVizForJob(svgContainer) {
         .append("g")
     }
 
+    // Now we need to shift the container for this stage so it doesn't overlap with
+    // existing ones, taking into account the position and width of the last stage's
+    // container. We do not need to do this for the first stage of this job.
+    if (i > 0) {
+      const lastStage = svgContainer.selectAll("g.cluster.stage")
+        .filter((d, i, nodes) => i === nodes.length - 1);
+      if (lastStage) {

Review Comment:
   The `lastStage` found previously was the stage to be prepended



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org