You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "SpriCoder (via GitHub)" <gi...@apache.org> on 2026/06/12 09:52:49 UTC
[PR] Remove unused PROJECT_SRC_DIR from cpp CMakeLists [tsfile]
SpriCoder opened a new pull request, #842:
URL: https://github.com/apache/tsfile/pull/842
## Summary
- Delete the dead `PROJECT_SRC_DIR` variable from `cpp/CMakeLists.txt`. It was introduced in #364 and has never been referenced anywhere in the build (verified across the full git history).
- Follow-up to the post-#829 review discussion: consumers (CLI, tests, examples, external users) should resolve library headers from the staged include tree (`LIBRARY_INCLUDE_DIR`) and link the shared library, never reach into `cpp/src` — so a variable pointing at the source tree should not exist as a temptation for future targets.
## Test plan
- [x] Fresh Debug configure + full build (`-DBUILD_TEST=ON -DENABLE_ANTLR4=OFF`): library, `tsfile-cli`, and `TsFile_Test` all compile and link.
- [x] Full GTest regression suite: 641 tests from 106 suites, all passed.
- [x] `tsfile-cli` smoke: `--version` / `--help`, plus a `write` (stdin CSV) → `count` → `cat` round-trip.
- [x] `grep PROJECT_SRC_DIR` over the repo and the generated `CMakeCache.txt`: zero remaining references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org