[jira] [Commented] (BEAM-986) ReduceFnRunner doesn't batch prefetching pane firings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716669#comment-15716669 ] 

ASF GitHub Bot commented on BEAM-986:
-------------------------------------

GitHub user scwhittle opened a pull request:

    https://github.com/apache/incubator-beam/pull/1493

    [BEAM-986] Deprecate TimerCallback and InMemoryTimerInternals methods using it.

    Deprecate TimerCallback and InMemoryTimerInternals methods using it.
    Instead separate advancing watermarks and removing eligible timers.
    SDK changes necessary for improving ReduceFnRunner prefetching.
    
    Hi @kennknowles , can you please take a look?  This is the sdk changes separated out from PR adding
    prefetching.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scwhittle/incubator-beam rm_timer_callback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1493
    
----
commit 550c6b05b426714f291174323366f82d34afeab3
Author: Sam Whittle <sa...@google.com>
Date:   2016-12-02T06:51:37Z

    Deprecate TimerCallback and InMemoryTimerInternals methods using it.
    Instead separate advancing watermarks and removing eligible timers.

----


> ReduceFnRunner doesn't batch prefetching pane firings
> -----------------------------------------------------
>
>                 Key: BEAM-986
>                 URL: https://issues.apache.org/jira/browse/BEAM-986
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Sam Whittle
>            Assignee: Sam Whittle
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Specifically
> - in ProcessElements, if there are multiple windows to consider each is processed sequentially with sequential state fetches instead of a bulk prefetch
> - onTimer method doesn't evaluate multiple timers at a time meaning that if multiple timers are fired at once each is processed sequentially without batched prefetching



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)