[jira] [Commented] (LANG-1028) CLONE - StringUtils.countMatches loops forever if substring empty

["Benedikt Ritter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067878#comment-14067878 ] 

Benedikt Ritter commented on LANG-1028:
---------------------------------------

Why has this ticket been opened? This issue has been fixed long time ago.

> CLONE - StringUtils.countMatches loops forever if substring empty
> -----------------------------------------------------------------
>
>                 Key: LANG-1028
>                 URL: https://issues.apache.org/jira/browse/LANG-1028
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>         Environment: Operating System: Linux
> Platform: PC
>            Reporter: stagiaire inria lille dascq
>
> If you do say StringUtils.countMatches("x", ""), then it goes into an infinite loop.
> Also sub isn't checked for null if str is null also. For instance
> StringUtils.countMatches(null, null) should throw an NPE instead of 0.
> To fix both problems put the following code at the start of the method:
> {code:java}
>         if (sub.equals("")) {
>             return 0;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)