You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/19 10:05:58 UTC

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4416: [ZEPPELIN-5773]Fix isWindowsPath Function in ZeppelinConfiguration Class

zjffdu commented on code in PR #4416:
URL: https://github.com/apache/zeppelin/pull/4416#discussion_r924310745


##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -327,7 +324,7 @@ public String getServerContextPath() {
 
   public String getKeyStorePath() {
     String path = getString(ConfVars.ZEPPELIN_SSL_KEYSTORE_PATH);
-    if (path != null && path.startsWith("/") || isWindowsPath(path)) {
+    if (path != null && path.startsWith("/") || isWindowsCheck()) {

Review Comment:
   Does just call `SystemUtils.IS_OS_WINDOWS` enough?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org