You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/02/01 04:55:16 UTC

[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2187: [MINOR] Negate sourceRow and targetRow presence conditions for readability

aokolnychyi commented on a change in pull request #2187:
URL: https://github.com/apache/iceberg/pull/2187#discussion_r567563485



##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -78,8 +78,8 @@ case class RewriteMergeInto(spark: SparkSession) extends Rule[LogicalPlan] with
         val joinPlan = Join(source, targetTableScan, LeftAnti, Some(cond), JoinHint.NONE)
 
         val mergeParams = MergeIntoParams(
-          isSourceRowNotPresent = FALSE_LITERAL,

Review comment:
       Will it be easier to reason about this logic in terms of `noMatchInSourceRelation`/`noMatchInTargetRelation`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org