You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/05/27 15:33:01 UTC

[GitHub] [storm] srdo commented on a change in pull request #3013: fix uploading dependency jars too slow when storm client and server located in different IDC

srdo commented on a change in pull request #3013: fix uploading dependency jars too slow when storm client and server located in different IDC
URL: https://github.com/apache/storm/pull/3013#discussion_r287827285
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/dependency/DependencyUploader.java
 ##########
 @@ -44,9 +51,12 @@
 
     private final Map<String, Object> conf;
     private ClientBlobStore blobStore;
+    private static final int DEFAULT_CHUCK_SIZE = 1024 * 1024;
 
 Review comment:
   I think this should go in https://github.com/apache/storm/blob/master/conf/defaults.yaml so it's obvious to users what the default value is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services