[GitHub] [spark] 10110346 edited a comment on issue #24187: [SPARK-27256][CORE][SQL]If the configuration is used to set the number of bytes, we'd better use `bytesConf`'.

[GitBox <gi...@apache.org>]

10110346 edited a comment on issue #24187: [SPARK-27256][CORE][SQL]If the configuration is used to set the number of bytes, we'd better use `bytesConf`'.
URL: https://github.com/apache/spark/pull/24187#issuecomment-476084268
 
 
   > 
   > 
   > We could have the same fix below, too?
   > 
   > [spark/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala](https://github.com/apache/spark/blob/8ec6cb67c71c67788230cab8a0cd34d8ad3ce24b/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala#L61)
   > 
   > Line 61 in [8ec6cb6](/apache/spark/commit/8ec6cb67c71c67788230cab8a0cd34d8ad3ce24b)
   >  val FILESOURCE_TABLE_RELATION_CACHE_SIZE = 
   > 
   > Anyway, have you checked all the related places for the same fix?
   
   Thanks.
   `FILESOURCE_TABLE_RELATION_CACHE_SIZE `  is used to  configure the number of entities, not the number of bytes.
   I've checked where `buildConf` and `ConfigBuilder` are called.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org