You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/11 14:20:51 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #12012: feat(dashboards): security perm simplification
dpgaspar opened a new pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `4.11%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.45% -4.12%
==========================================
Files 959 960 +1
Lines 47161 47185 +24
Branches 4613 4613
==========================================
- Hits 31864 29939 -1925
- Misses 15185 17062 +1877
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.69% <100.00%> (+0.02%)` | :arrow_up: |
| python | `63.90% <24.39%> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.45% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (9c42437) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.95%`.
> The diff coverage is `24.39%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.93% -3.96%
==========================================
Files 948 472 -476
Lines 46177 29050 -17127
Branches 4405 0 -4405
==========================================
- Hits 31348 18572 -12776
+ Misses 14722 10478 -4244
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.93% <24.39%> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| ... and [494 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...9c42437](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (9c42437) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.43%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.45% -4.44%
==========================================
Files 948 953 +5
Lines 46177 46694 +517
Branches 4405 4577 +172
==========================================
- Hits 31348 29630 -1718
- Misses 14722 16879 +2157
- Partials 107 185 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <100.00%> (-0.29%)` | :arrow_down: |
| python | `63.93% <24.39%> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [212 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...9c42437](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (191382a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.14%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.73% -4.15%
==========================================
Files 948 472 -476
Lines 46177 29022 -17155
Branches 4405 0 -4405
==========================================
- Hits 31348 18498 -12850
+ Misses 14722 10524 -4198
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.73% <25.00%> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [492 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...191382a](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (1bfc1d1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.00%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.88% -4.01%
==========================================
Files 948 472 -476
Lines 46177 29022 -17155
Branches 4405 0 -4405
==========================================
- Hits 31348 18541 -12807
+ Misses 14722 10481 -4241
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <25.00%> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...1bfc1d1](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `3.93%`.
> The diff coverage is `24.39%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.62% -3.94%
==========================================
Files 959 477 -482
Lines 47161 29423 -17738
Branches 4613 0 -4613
==========================================
- Hits 31864 18721 -13143
+ Misses 15185 10702 -4483
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.62% <24.39%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `3.88%`.
> The diff coverage is `24.39%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.68% -3.89%
==========================================
Files 959 477 -482
Lines 47161 29423 -17738
Branches 4613 0 -4613
==========================================
- Hits 31864 18737 -13127
+ Misses 15185 10686 -4499
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <24.39%> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.45% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `4.25%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.31% -4.26%
==========================================
Files 959 960 +1
Lines 47161 47185 +24
Branches 4613 4613
==========================================
- Hits 31864 29873 -1991
- Misses 15185 17128 +1943
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.69% <100.00%> (+0.02%)` | :arrow_up: |
| python | `63.68% <24.39%> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.45% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `3.92%`.
> The diff coverage is `24.39%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.63% -3.93%
==========================================
Files 959 477 -482
Lines 47161 29408 -17753
Branches 4613 0 -4613
==========================================
- Hits 31864 18714 -13150
+ Misses 15185 10694 -4491
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <24.39%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [494 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (9c42437) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.41%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.47% -4.42%
==========================================
Files 948 953 +5
Lines 46177 46709 +532
Branches 4405 4577 +172
==========================================
- Hits 31348 29648 -1700
- Misses 14722 16876 +2154
- Partials 107 185 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <100.00%> (-0.29%)` | :arrow_down: |
| python | `63.96% <24.39%> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [202 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...9c42437](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (1bfc1d1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.37%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 64.50% -3.38%
==========================================
Files 948 472 -476
Lines 46177 29022 -17155
Branches 4405 0 -4405
==========================================
- Hits 31348 18722 -12626
+ Misses 14722 10300 -4422
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.50% <25.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.75% <0.00%> (-0.65%)` | :arrow_down: |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | | |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | | |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...191382a](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `3.89%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.66% -3.90%
==========================================
Files 959 960 +1
Lines 47161 47185 +24
Branches 4613 4613
==========================================
- Hits 31864 30041 -1823
- Misses 15185 16960 +1775
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.69% <100.00%> (+0.02%)` | :arrow_up: |
| python | `64.25% <24.39%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.45% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (9c42437) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.00%`.
> The diff coverage is `24.39%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.87% -4.01%
==========================================
Files 948 472 -476
Lines 46177 29050 -17127
Branches 4405 0 -4405
==========================================
- Hits 31348 18557 -12791
+ Misses 14722 10493 -4229
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.87% <24.39%> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `78.00% <0.00%> (-13.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...9c42437](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (1bfc1d1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.30%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.57% -4.31%
==========================================
Files 948 472 -476
Lines 46177 29007 -17170
Branches 4405 0 -4405
==========================================
- Hits 31348 18442 -12906
+ Misses 14722 10565 -4157
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.57% <25.00%> (-1.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...1bfc1d1](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (191382a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.15%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.73% -4.16%
==========================================
Files 948 472 -476
Lines 46177 29020 -17157
Branches 4405 0 -4405
==========================================
- Hits 31348 18496 -12852
+ Misses 14722 10524 -4198
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.73% <25.00%> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [493 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...191382a](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (b7ccea4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/48fb8c0b7793e6b618db8c229101075c44c2bac2?el=desc) (48fb8c0) will **decrease** coverage by `4.24%`.
> The diff coverage is `24.39%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.56% 63.32% -4.25%
==========================================
Files 959 477 -482
Lines 47161 29408 -17753
Branches 4613 0 -4613
==========================================
- Hits 31864 18622 -13242
+ Misses 15185 10786 -4399
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.32% <24.39%> (-0.99%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| ... and [508 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [48fb8c0...b7ccea4](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (9c42437) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.40%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.47% -4.41%
==========================================
Files 948 953 +5
Lines 46177 46694 +517
Branches 4405 4577 +172
==========================================
- Hits 31348 29641 -1707
- Misses 14722 16868 +2146
- Partials 107 185 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <100.00%> (-0.29%)` | :arrow_down: |
| python | `63.96% <24.39%> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [209 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...9c42437](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12012: feat(dashboards): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12012:
URL: https://github.com/apache/incubator-superset/pull/12012#issuecomment-743289918
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=h1) Report
> Merging [#12012](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=desc) (9c42437) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.15%`.
> The diff coverage is `35.41%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12012 +/- ##
==========================================
- Coverage 67.88% 63.73% -4.16%
==========================================
Files 948 953 +5
Lines 46177 46709 +532
Branches 4405 4577 +172
==========================================
- Hits 31348 29770 -1578
- Misses 14722 16754 +2032
- Partials 107 185 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <100.00%> (-0.29%)` | :arrow_down: |
| python | `64.37% <24.39%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...sions/1f6dca87d1a2\_security\_converge\_dashboards.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZjZkY2E4N2QxYTJfc2VjdXJpdHlfY29udmVyZ2VfZGFzaGJvYXJkcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `75.67% <100.00%> (-13.52%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.31% <100.00%> (-1.84%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.58% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `72.97% <100.00%> (+2.38%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [199 more](https://codecov.io/gh/apache/incubator-superset/pull/12012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=footer). Last update [916f7e9...9c42437](https://codecov.io/gh/apache/incubator-superset/pull/12012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org