You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/04/18 22:37:41 UTC
[kudu-CR] [test] avoid coredump in socket-test when failing
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18425
Change subject: [test] avoid coredump in socket-test when failing
......................................................................
[test] avoid coredump in socket-test when failing
I noticed the socket-test crashed when SocketTest.TestRecvReset failed
with the stack trace below. This patch updates the code to at least
avoid the crash in case of a failure.
src/kudu/util/net/socket-test.cc:144: Failure
Value of: s.message().ToString()
Expected: contains regular expression "recv error from 127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not connected"
terminating
*** Aborted at 1650307680 (unix time) try "date -d @1650307680" if you are using GNU date ***
PC: @ 0x7f37ddbe0fb7 gsignal
*** SIGABRT (@0x3e800005198) received by PID 20888 (TID 0x7f37e10253c0) from PID 20888; stack trace: ***
@ 0x437b40 __tsan::CallUserSignalHandler()
@ 0x43a274 rtl_sigaction()
@ 0x7f37de1bd980 (unknown) at ??:0
@ 0x7f37ddbe0fb7 gsignal at ??:0
@ 0x7f37ddbe2921 abort at ??:0
@ 0x43bfd7 __interceptor_abort
@ 0x7f37de791a05 abort_message at ??:0
@ 0x7f37de7763be demangling_terminate_handler() at ??:0
@ 0x7f37de790b58 std::__terminate() at ??:0
@ 0x7f37de790ae8 std::terminate() at ??:0
@ 0x7f37dea76b81 std::__1::thread::~thread() at ??:0
@ 0x4dc097 kudu::SocketTest::DoTestServerDisconnects() at src/kudu/util/net/socket-test.cc:147
@ 0x4db093 kudu::SocketTest_TestRecvReset_Test::TestBody() at src/kudu/util/net/socket-test.cc:?
@ 0x7f37df11d500 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f37df0f2452 testing::Test::Run() at ??:0
@ 0x7f37df0f39ea testing::TestInfo::Run() at ??:0
@ 0x7f37df0f4757 testing::TestSuite::Run() at ??:0
@ 0x7f37df108527 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7f37df11e6e0 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f37df107acd testing::UnitTest::Run() at ??:0
@ 0x7f37e11c2e1c RUN_ALL_TESTS() at ??:0
@ 0x7f37e11c1c6a main at ??:0
@ 0x7f37ddbc3bf7 __libc_start_main at ??:0
@ 0x4306ad (unknown) at ??:?
Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
---
M src/kudu/util/net/socket-test.cc
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/18425/1
--
To view, visit http://gerrit.cloudera.org:8080/18425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
Gerrit-Change-Number: 18425
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [test] avoid coredump in socket-test when failing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18425 )
Change subject: [test] avoid coredump in socket-test when failing
......................................................................
Patch Set 1: Verified+1
unrelated failure in reading master-stress-test.xml
--
To view, visit http://gerrit.cloudera.org:8080/18425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
Gerrit-Change-Number: 18425
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 03:22:59 +0000
Gerrit-HasComments: No
[kudu-CR] [test] avoid coredump in socket-test when failing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [test] avoid coredump in socket-test when failing
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
Gerrit-Change-Number: 18425
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [test] avoid coredump in socket-test when failing
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18425 )
Change subject: [test] avoid coredump in socket-test when failing
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
Gerrit-Change-Number: 18425
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 00:07:57 +0000
Gerrit-HasComments: No
[kudu-CR] [test] avoid coredump in socket-test when failing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18425 )
Change subject: [test] avoid coredump in socket-test when failing
......................................................................
[test] avoid coredump in socket-test when failing
I noticed the socket-test crashed when SocketTest.TestRecvReset failed
with the stack trace below. This patch updates the code to at least
avoid the crash in case of a failure.
src/kudu/util/net/socket-test.cc:144: Failure
Value of: s.message().ToString()
Expected: contains regular expression "recv error from 127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not connected"
terminating
*** Aborted at 1650307680 (unix time) try "date -d @1650307680" if you are using GNU date ***
PC: @ 0x7f37ddbe0fb7 gsignal
*** SIGABRT (@0x3e800005198) received by PID 20888 (TID 0x7f37e10253c0) from PID 20888; stack trace: ***
@ 0x437b40 __tsan::CallUserSignalHandler()
@ 0x43a274 rtl_sigaction()
@ 0x7f37de1bd980 (unknown) at ??:0
@ 0x7f37ddbe0fb7 gsignal at ??:0
@ 0x7f37ddbe2921 abort at ??:0
@ 0x43bfd7 __interceptor_abort
@ 0x7f37de791a05 abort_message at ??:0
@ 0x7f37de7763be demangling_terminate_handler() at ??:0
@ 0x7f37de790b58 std::__terminate() at ??:0
@ 0x7f37de790ae8 std::terminate() at ??:0
@ 0x7f37dea76b81 std::__1::thread::~thread() at ??:0
@ 0x4dc097 kudu::SocketTest::DoTestServerDisconnects() at src/kudu/util/net/socket-test.cc:147
@ 0x4db093 kudu::SocketTest_TestRecvReset_Test::TestBody() at src/kudu/util/net/socket-test.cc:?
@ 0x7f37df11d500 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f37df0f2452 testing::Test::Run() at ??:0
@ 0x7f37df0f39ea testing::TestInfo::Run() at ??:0
@ 0x7f37df0f4757 testing::TestSuite::Run() at ??:0
@ 0x7f37df108527 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7f37df11e6e0 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f37df107acd testing::UnitTest::Run() at ??:0
@ 0x7f37e11c2e1c RUN_ALL_TESTS() at ??:0
@ 0x7f37e11c1c6a main at ??:0
@ 0x7f37ddbc3bf7 __libc_start_main at ??:0
@ 0x4306ad (unknown) at ??:?
Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
Reviewed-on: http://gerrit.cloudera.org:8080/18425
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/net/socket-test.cc
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cf8f7b9acfac7b1935e6e6d9b3ac5016ee753d9
Gerrit-Change-Number: 18425
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>