[GitHub] [celix] pnoltes commented on a diff in pull request #446: Feature/separate deprecated headers

[GitBox <gi...@apache.org>]

pnoltes commented on code in PR #446:
URL: https://github.com/apache/celix/pull/446#discussion_r986018191


##########
cmake/celix_project/CelixProject.cmake:
##########
@@ -83,5 +83,31 @@ MACRO(celix_subproject)
     ENDIF (${NAME})
 ENDMACRO(celix_subproject)
 
+#[[
+Custom target which list the Celix CMake targets that are still using deprecated headers.
+]]
+if (NOT TARGET celix-deprecated)
+    add_custom_target(celix-deprecated
+        COMMAND ${CMAKE_COMMAND} -E echo "Targets still using deprecated utils headers: $<JOIN:$<TARGET_PROPERTY:celix-deprecated,UTIL_TARGETS>, >"
+    )
+    set_target_properties(celix-deprecated PROPERTIES "UTIL_TARGETS" "")
+endif ()
+
+
+#[[
+Add include path for the Celix utils deprecated headers to the provided target (as PRIVATE)
+
+```CMake
+celix_v2_utils_headers(<target_name>))

Review Comment:
   yes and now updated this



##########
libs/utils/include_deprecated/linked_list.h:
##########
@@ -32,63 +32,57 @@
 #include "celix_errno.h"
 #include "exports.h"
 
-#ifdef ADD_CELIX_DEPRECATED_WARNING
-#define CELIX_DEPRECATED_ATTR __attribute__ ((deprecated))
-#else
-#define CELIX_DEPRECATED_ATTR
-#endif
-
 #ifdef __cplusplus
 extern "C" {
 #endif
-typedef struct linked_list_entry *linked_list_entry_pt; //TODO make deprecated
-typedef struct linked_list *linked_list_pt; //TODO make deprecated
+typedef struct linked_list_entry *linked_list_entry_pt;

Review Comment:
   > There was a note with `TODO make deprecated`. Why only mark the `linked_list_pt` as deprecated and not this one?
   
   Now linked_list_entry is also marked as deprecated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org