[GitHub] [trafficcontrol] rob05c opened a new pull request #3943: Fix Traffic Ops missing error check

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #3943: Fix Traffic Ops missing error check
URL: https://github.com/apache/trafficcontrol/pull/3943
 
 
   # What does this PR (Pull Request) do?
   
   Fixes Traffic Ops missing an error check in the servers assignment endpoint.
   
   Also fixes double-logging errors.
   
   Tests for DSS endpoints already exist. This only happens on database error, it's not possible to simulate this particular error.
   
   No documentation, no interface change.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   Run TO API Tests. Verify `servers/{id}/deliveryservices` endpoint works as expected.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - 2.2.0
   - 3.0.0
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services