You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/06 20:40:33 UTC
Review Request 16663: Added --with-cxx11 to libprocess configuration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16663/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
When building with clang we assume --with-cxx11. For example:
CC=/path/to/clang CXX=/path/to/clang++ ../configure
But when building with gcc 4.8 you need to specify C++11:
CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11
Diffs
-----
3rdparty/libprocess/configure.ac d3b86a3d6360d146fda1789ed479f8c5acd6e8fd
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/16663/diff/
Testing
-------
$ CC=/path/to/clang CXX=/path/to/clang++ ../configure && make check
$ CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 && make check
Thanks,
Benjamin Hindman
Re: Review Request 16663: Added --with-cxx11 to libprocess configuration.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16663/#review31561
-----------------------------------------------------------
Ship it!
- Ben Mahler
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16663/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When building with clang we assume --with-cxx11. For example:
>
> CC=/path/to/clang CXX=/path/to/clang++ ../configure
>
> But when building with gcc 4.8 you need to specify C++11:
>
> CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac d3b86a3d6360d146fda1789ed479f8c5acd6e8fd
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16663/diff/
>
>
> Testing
> -------
>
> $ CC=/path/to/clang CXX=/path/to/clang++ ../configure && make check
> $ CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 && make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16663: Added --with-cxx11 to libprocess configuration.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 7, 2014, 8:02 a.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/configure.ac, line 75
> > <https://reviews.apache.org/r/16663/diff/1/?file=417616#file417616line75>
> >
> > Tiny nit; One space too many in front?
Thank you!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16663/#review31294
-----------------------------------------------------------
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16663/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When building with clang we assume --with-cxx11. For example:
>
> CC=/path/to/clang CXX=/path/to/clang++ ../configure
>
> But when building with gcc 4.8 you need to specify C++11:
>
> CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac d3b86a3d6360d146fda1789ed479f8c5acd6e8fd
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16663/diff/
>
>
> Testing
> -------
>
> $ CC=/path/to/clang CXX=/path/to/clang++ ../configure && make check
> $ CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 && make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16663: Added --with-cxx11 to libprocess configuration.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16663/#review31294
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/16663/#comment59720>
Tiny nit; One space too many in front?
- Niklas Nielsen
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16663/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When building with clang we assume --with-cxx11. For example:
>
> CC=/path/to/clang CXX=/path/to/clang++ ../configure
>
> But when building with gcc 4.8 you need to specify C++11:
>
> CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac d3b86a3d6360d146fda1789ed479f8c5acd6e8fd
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16663/diff/
>
>
> Testing
> -------
>
> $ CC=/path/to/clang CXX=/path/to/clang++ ../configure && make check
> $ CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 && make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>