You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/15 06:19:00 UTC
[GitHub] [pulsar] shustsud opened a new pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
shustsud opened a new pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066
### Motivation
After replicated subscription is deleted by checkInactiveSubscriptions, replicated subscription will be recreated.
Replicated subscriptions are created with receiveSubscriptionUpdated.
In this case, position becomes latest position.
[https://github.com/apache/pulsar/blob/757824f88c06feb97968af6f5cdd7ccbea5ac666/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L182-L183](https://github.com/apache/pulsar/blob/757824f88c06feb97968af6f5cdd7ccbea5ac666/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L182-L183)
I think replicated subscription should be excluded from automatic deletion.
### Modifications
* Fixed PersistentTopic.
* Fixed PersistentTopicTest.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nkurihar commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
nkurihar commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-692535446
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-692663048
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-693045340
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-693017603
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-693091555
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-693102693
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shustsud commented on pull request #8066: [broker] Add replicated check to checkInactiveSubscriptions.
Posted by GitBox <gi...@apache.org>.
shustsud commented on pull request #8066:
URL: https://github.com/apache/pulsar/pull/8066#issuecomment-693112190
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org