You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/26 03:16:08 UTC
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #7888: refractored Charsets to StandardCharsets Fixes #7884
menghaoranss commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r511700497
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
for (WatchEvent each : response.getEvents()) {
ChangedType changedType = getEventChangedType(each);
if (ChangedType.IGNORED != changedType) {
- dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+ dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+ , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));
Review comment:
`,` must be on the first line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org