You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/01 08:32:05 UTC

[GitHub] [shardingsphere] lanchengx opened a new pull request #13386: Replace `assertEqual` with `assertThat`

lanchengx opened a new pull request #13386:
URL: https://github.com/apache/shardingsphere/pull/13386


   Changes proposed in this pull request:
   - Replace `assertEqual` with `assertThat`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lanchengx commented on a change in pull request #13386: Replace `assertEqual` with `assertThat`

Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #13386:
URL: https://github.com/apache/shardingsphere/pull/13386#discussion_r740115467



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/test/java/org/apache/shardingsphere/sharding/distsql/update/AlterShardingTableRuleStatementUpdaterTest.java
##########
@@ -93,21 +94,21 @@ public void assertUpdate() throws DistSQLException {
         updater.checkSQLStatement(shardingSphereMetaData, statement, currentRuleConfiguration);
         ShardingRuleConfiguration toBeAlteredRuleConfiguration = updater.buildToBeAlteredRuleConfiguration(statement);
         updater.updateCurrentRuleConfiguration(currentRuleConfiguration, toBeAlteredRuleConfiguration);
-        Assert.assertEquals(1, currentRuleConfiguration.getTables().size());
+        Assert.assertThat(currentRuleConfiguration.getTables().size(), is(1));

Review comment:
       thanks, I will use another pr to modify




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13386: Replace `assertEqual` with `assertThat`

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13386:
URL: https://github.com/apache/shardingsphere/pull/13386#discussion_r740038165



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/test/java/org/apache/shardingsphere/sharding/distsql/update/AlterShardingTableRuleStatementUpdaterTest.java
##########
@@ -93,21 +94,21 @@ public void assertUpdate() throws DistSQLException {
         updater.checkSQLStatement(shardingSphereMetaData, statement, currentRuleConfiguration);
         ShardingRuleConfiguration toBeAlteredRuleConfiguration = updater.buildToBeAlteredRuleConfiguration(statement);
         updater.updateCurrentRuleConfiguration(currentRuleConfiguration, toBeAlteredRuleConfiguration);
-        Assert.assertEquals(1, currentRuleConfiguration.getTables().size());
+        Assert.assertThat(currentRuleConfiguration.getTables().size(), is(1));

Review comment:
       Consider using static import here and below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang merged pull request #13386: Replace `assertEqual` with `assertThat`

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #13386:
URL: https://github.com/apache/shardingsphere/pull/13386


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org