[GitHub] [incubator-samoa] csterling commented on a change in pull request #70: SAMOA-72 New Boosting algorithm for VHT

[GitBox <gi...@apache.org>]

csterling commented on a change in pull request #70: SAMOA-72 New Boosting algorithm for VHT
URL: https://github.com/apache/incubator-samoa/pull/70#discussion_r347663873
 
 

 ##########
 File path: samoa-api/src/main/java/org/apache/samoa/learners/classifiers/trees/LocalStatisticsProcessor.java
 ##########
 @@ -180,16 +208,16 @@ public Processor newProcessor(Processor p) {
    * 
    * @param computeStream
    */
-  void setComputationResultStream(Stream computeStream) {
+  public void setComputationResultStream(Stream computeStream) {
     this.computationResultStream = computeStream;
   }
 
   private AttributeClassObserver newNominalClassObserver() {
-    return (AttributeClassObserver) this.nominalClassObserver.copy();
+    return new NominalAttributeClassObserver(); //further investigate this change
   }
 
   private AttributeClassObserver newNumericClassObserver() {
-    return (AttributeClassObserver) this.numericClassObserver.copy();
+    return new GaussianNumericAttributeClassObserver();//further investigate this change
 
 Review comment:
   @fobeligi Can you please comment on why this change was necessary, and the implications of it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services