You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/18 07:50:10 UTC

[GitHub] [incubator-nuttx] raiden00pl commented on issue #1416: nRF52 radio adaptation

raiden00pl commented on issue #1416:
URL: https://github.com/apache/incubator-nuttx/issues/1416#issuecomment-660445400


   >  The RADIO peripheral interface is currently written as it were a driver supporting multiple instances of the RADIO (ie RADIO0, RADIO1). This makes no sense since, to my knowledge, there is no nRF52 part having more than one RADIO.
   
   It's done on purpose. For now there is no multi-radio chips, but in the future who knows?
   
   > I would like to simplify nrf52_radio to remove all logic which assumes another RADIO instance. This means to simplify interface to be based on direct function calls and not calls via "ops" struct.
   
   Don't like this. I don't see any added value in the proposed solution and more - it is less modular.
   
   > The second modification would be to remove internal mutex use and ISR registration and have read/write functions simply return and let the driver using this interface handle the ISR.
   
   Remember that RADIO can be also used to implement simple proprietary protocols. The default interrupt logic can be useful in this case. 
   It may be better to provide a configuration option to disable default interrupts and expose the interrupts interface.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org