You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/01 15:15:55 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7285: ARROW-8843: [C++] Compare bitmaps in words

wesm commented on a change in pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#discussion_r433296037



##########
File path: cpp/src/arrow/util/bit_util.cc
##########
@@ -246,6 +246,49 @@ bool BitmapEquals(const uint8_t* left, int64_t left_offset, const uint8_t* right
   }
 
   // Unaligned slow case
+  left += left_offset / 8;
+  right += right_offset / 8;
+  left_offset %= 8;
+  right_offset %= 8;
+
+  // process in 64 bits
+  int64_t nwords = bit_length / 64;

Review comment:
       https://google.github.io/styleguide/cppguide.html
   
   We indeed use snake_case for member accessors (this used to be the guidance in the Google C++ style guide but they might have made some changes). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org