You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/02 13:07:05 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7335: [AIRFLOW-6711]
Drop plugin support for stat_name_handler
mik-laj opened a new pull request #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler
URL: https://github.com/apache/airflow/pull/7335
This change is intended to simplify the statsd configuration and unify the configuration. Other components use import path to configure aplication e.g.. `pod_mutation_hook` or `auth_backend`. Configuration through plugins is very strange and may not be readable enough. The configuration file for the configuration is a proven, stable and widely used solution. Plugins are an interesting idea, but they are not common.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7335:
[AIRFLOW-6711] Drop plugin support for stat_name_handler
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler
URL: https://github.com/apache/airflow/pull/7335#issuecomment-581179065
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=h1) Report
> Merging [#7335](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf141506a25dbba279b85500d781f7e056540721?src=pr&el=desc) will **increase** coverage by `53.15%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7335/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7335 +/- ##
===========================================
+ Coverage 32.86% 86.01% +53.15%
===========================================
Files 867 867
Lines 40560 40556 -4
===========================================
+ Hits 13331 34886 +21555
+ Misses 27229 5670 -21559
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <100%> (+0.65%)` | :arrow_up: |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `90.47% <100%> (+37.97%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
| ... and [735 more](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=footer). Last update [cf14150...d83554a](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7335: [AIRFLOW-6711] Drop
plugin support for stat_name_handler
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler
URL: https://github.com/apache/airflow/pull/7335#issuecomment-581182686
Let's wait for @milton0825 He may have had an unknown reason to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7335: [AIRFLOW-6711] Drop
plugin support for stat_name_handler
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler
URL: https://github.com/apache/airflow/pull/7335#issuecomment-581179065
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=h1) Report
> Merging [#7335](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf141506a25dbba279b85500d781f7e056540721?src=pr&el=desc) will **increase** coverage by `53.15%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7335/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7335 +/- ##
===========================================
+ Coverage 32.86% 86.01% +53.15%
===========================================
Files 867 867
Lines 40560 40556 -4
===========================================
+ Hits 13331 34886 +21555
+ Misses 27229 5670 -21559
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <100%> (+0.65%)` | :arrow_up: |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `90.47% <100%> (+37.97%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
| ... and [738 more](https://codecov.io/gh/apache/airflow/pull/7335/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=footer). Last update [cf14150...d83554a](https://codecov.io/gh/apache/airflow/pull/7335?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7335: [AIRFLOW-6711] Drop
plugin support for stat_name_handler
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler
URL: https://github.com/apache/airflow/pull/7335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services