You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/14 13:02:42 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1771: chore: improve Route module
juzhiyuan opened a new pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
According to https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L335
- [x] added Methods for http_methods;
- [x] added i18n for Advaned Route Match
- [ ] ...
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* processing.
Building with commit 1927e132a5016670bb81ba15abac5b8f660deb6e
https://app.netlify.com/sites/apisix-dashboard/deploys/6077bb763903f0000881ef5d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#discussion_r613722377
##########
File path: web/cypress/fixtures/export-route-dataset.json
##########
@@ -8,8 +8,8 @@
"openapi": "3.0.0",
"paths": {
"/{params}": {
- "get": {
- "operationId": "route_name_0GET",
+ "post": {
Review comment:
The test case for import and export is using POST, then I updated the dataset file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* ready!
Built with commit d070f65afdd279853ae88054e7865732a9f02af7
https://deploy-preview-1771--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#discussion_r613720694
##########
File path: web/cypress/fixtures/export-route-dataset.json
##########
@@ -8,8 +8,8 @@
"openapi": "3.0.0",
"paths": {
"/{params}": {
- "get": {
- "operationId": "route_name_0GET",
+ "post": {
Review comment:
why change `get` to `post`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* ready!
Built with commit 2184e7c18cd457f2f7a503a3d7f57c1a2d7f723a
https://deploy-preview-1771--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* processing.
Building with commit d070f65afdd279853ae88054e7865732a9f02af7
https://app.netlify.com/sites/apisix-dashboard/deploys/6077631f4bb0ac0007b34d85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* ready!
Built with commit 49ef75774d777b7f6c2be0fc69186998d834d1b9
https://deploy-preview-1771--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1771: feat: added sample for vars in Route & improve Typings
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* processing.
Building with commit f6f2995f456228f5620927f0b69c0d35f1a7d1c2
https://app.netlify.com/sites/apisix-dashboard/deploys/6076e7e7773b4200082b63fb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* ready!
Built with commit f6f2995f456228f5620927f0b69c0d35f1a7d1c2
https://deploy-preview-1771--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* processing.
Building with commit 49ef75774d777b7f6c2be0fc69186998d834d1b9
https://app.netlify.com/sites/apisix-dashboard/deploys/6077974fb206ce0008107682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* processing.
Building with commit 2184e7c18cd457f2f7a503a3d7f57c1a2d7f723a
https://app.netlify.com/sites/apisix-dashboard/deploys/6076f6034f2d570007a16737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1771: feat: added sample for vars in Route & improve Typings
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1771:
URL: https://github.com/apache/apisix-dashboard/pull/1771#issuecomment-819500106
Deploy preview for *apisix-dashboard* ready!
Built with commit 1927e132a5016670bb81ba15abac5b8f660deb6e
https://deploy-preview-1771--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org