You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2025/04/17 03:11:05 UTC

(kafka) branch trunk updated: HOTFIX: add SuppressWarnings to TieredStorageTestUtils (#19494)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new b4e75fbab1f HOTFIX: add SuppressWarnings to TieredStorageTestUtils (#19494)
b4e75fbab1f is described below

commit b4e75fbab1f2aa2528b252da7835ecd8848215fb
Author: Ken Huang <s7...@gmail.com>
AuthorDate: Thu Apr 17 11:10:59 2025 +0800

    HOTFIX: add SuppressWarnings to TieredStorageTestUtils (#19494)
    
    We need add SuppressWarnings annotation, because `log.cleaner.enable`
    mark deprecated.
    
    Reviewers: PoAn Yang <pa...@apache.org>, Kuan-Po Tseng
    <br...@gmail.com>, TengYao Chi <ki...@gmail.com>, Chia-Ping Tsai
    <ch...@gmail.com>
---
 .../apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java b/storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java
index ca20ab3689f..1db34ebafcb 100644
--- a/storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java
+++ b/storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java
@@ -27,6 +27,7 @@ import org.apache.kafka.server.config.ServerLogConfigs;
 import org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManager;
 import org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerConfig;
 import org.apache.kafka.server.log.remote.storage.LocalTieredStorage;
+import org.apache.kafka.storage.internals.log.CleanerConfig;
 import org.apache.kafka.tiered.storage.TieredStorageTestContext;
 
 import org.junit.jupiter.api.Assertions;
@@ -53,7 +54,6 @@ import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.
 import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP;
 import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CLASS_NAME_PROP;
 import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP;
-import static org.apache.kafka.storage.internals.log.CleanerConfig.LOG_CLEANER_ENABLE_PROP;
 
 public class TieredStorageTestUtils {
 
@@ -103,6 +103,7 @@ public class TieredStorageTestUtils {
                 .toList();
     }
 
+    @SuppressWarnings("removal")
     public static Properties createPropsForRemoteStorage(String testClassName,
                                                          String storageDirPath,
                                                          int brokerCount,
@@ -158,7 +159,7 @@ public class TieredStorageTestUtils {
         // Set 2 log dirs to make sure JBOD feature is working correctly
         overridingProps.setProperty(ServerLogConfigs.LOG_DIRS_CONFIG, TestUtils.tempDir().getAbsolutePath() + "," + TestUtils.tempDir().getAbsolutePath());
         // Disable unnecessary log cleaner
-        overridingProps.setProperty(LOG_CLEANER_ENABLE_PROP, "false");
+        overridingProps.setProperty(CleanerConfig.LOG_CLEANER_ENABLE_PROP, "false");
 
         return overridingProps;
     }