You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/17 19:44:09 UTC

[GitHub] [airflow] VijayantSoni edited a comment on pull request #8701: Adding ElastiCache Hook for creating, describing and deleting replication groups

VijayantSoni edited a comment on pull request #8701:
URL: https://github.com/apache/airflow/pull/8701#issuecomment-629850001


   @ashb Made the changes as per your suggestion. Also added unit tests, but moto does not support mocking aws elasticache hence the tests won't run.
   I looked at other tests and tried following:
   ```python
   try:
       from moto import mock_elasticache
   except ImportError:
       mock_elasticache = None
   
   
   @unittest.skipIf(mock_elasticache is None, 'mock_elasticache package not available')
   ```
   But this does not seem to work, we do get following error:
   ```
   @mock_elasticache
   E   TypeError: 'NoneType' object is not callable
   ```
   
   Let me know if there is some other way run the tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org