You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by twdsilva <gi...@git.apache.org> on 2018/12/01 00:26:07 UTC

[GitHub] phoenix pull request #408: PHOENIX-4763: Changing a base table property valu...

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/408#discussion_r238039864
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ---
    @@ -1447,6 +1457,12 @@ private PTable getTable(RegionScanner scanner, long clientTimeStamp, long tableT
             long updateCacheFrequency = updateCacheFrequencyKv == null ? 0 :
                 PLong.INSTANCE.getCodec().decodeLong(updateCacheFrequencyKv.getValueArray(),
                         updateCacheFrequencyKv.getValueOffset(), SortOrder.getDefault());
    +
    +        // Check the cell tag to see whether the view has modified this property
    +        byte[] tagUpdateCacheFreq = (updateCacheFrequencyKv == null) ? HConstants.EMPTY_BYTE_ARRAY :
    +                TagUtil.concatTags(HConstants.EMPTY_BYTE_ARRAY, updateCacheFrequencyKv);
    --- End diff --
    
    Currently we only have a single cell tag, but just in case can you search if the byte[] contains the tag insteads of starts with.


---