You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by jrushford <gi...@git.apache.org> on 2017/05/25 18:51:08 UTC
[GitHub] incubator-trafficcontrol pull request #616: Modified astats_over_http to rep...
GitHub user jrushford opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/616
Modified astats_over_http to report the speed of all network interfaces.
astats_over_http did not correctly report the interface speed of hosts not using bonding. Also, since interface name is passed to astats, it is not necessary to read the bonding_masters file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jrushford/incubator-trafficcontrol astats_getspeed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #616
----
commit d1d139374a694311f739556df37f2be888bb06a3
Author: John J. Rushford <jr...@apache.org>
Date: 2017-05-25T17:20:55Z
Modified astats_over_http to skip reading the bonding_masters file as the
interface is specified in the call to astats.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
@smalenfant can you take a look at this PR and maybe give it a quick test? John and I had a chat about the implementation and it seemed like removing the part that finds individual interfaces was unnecessary. I'd like a second opinion to validate our assumptions.
John said he tested on 7.2 and 7.3 and didn't see any issues; bonded and non-bonded interfaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
Great. Thanks for the help testing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by smalenfant <gi...@git.apache.org>.
Github user smalenfant commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
Centos 7.3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
Thanks for the testing @smalenfant
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
John_Rushford@cable.comcast.com
From: Jeff Elsloo <no...@github.com>
Reply-To: apache/incubator-trafficcontrol <re...@reply.github.com>
Date: Friday, May 26, 2017 at 9:22 AM
To: apache/incubator-trafficcontrol <in...@noreply.github.com>
Cc: John Rushford <Jo...@cable.comcast.com>, Author <au...@noreply.github.com>
Subject: Re: [apache/incubator-trafficcontrol] Modified astats_over_http to report the speed of all network interfaces. (#616)
Great. Thanks for the help testing!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-trafficcontrol/pull/616#issuecomment-304311292>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEVybsXa9GHelqoh68Qei5vPGRvQK_5Xks5r9u5HgaJpZM4Nmv7Q>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by smalenfant <gi...@git.apache.org>.
Github user smalenfant commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
@elsloo Tested on Centos 6 (single interface) and Centos 7 (single and bond). All looks good. :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #616: Modified astats_over_http to rep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/616
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by smalenfant <gi...@git.apache.org>.
Github user smalenfant commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
That's what I was thinking about first time I looked at this. Not sure why
we needed to iterate all the slaves. We can put this through the test, but
it looks good to me.
On Thu, May 25, 2017 at 3:09 PM, Jeff Elsloo <no...@github.com>
wrote:
> @smalenfant <https://github.com/smalenfant> can you take a look at this
> PR and maybe give it a quick test? John and I had a chat about the
> implementation and it seemed like removing the part that finds individual
> interfaces was unnecessary. I'd like a second opinion to validate our
> assumptions.
>
> John said he tested on 7.2 and 7.3 and didn't see any issues; bonded and
> non-bonded interfaces.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-trafficcontrol/pull/616#issuecomment-304096993>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADoJyEbN38oekoxGyn9Rw-Nm9Hbe4kjfks5r9dIEgaJpZM4Nmv7Q>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
@smalenfant thanks, let us know how the testing goes on your side so we can merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/616
Which version of CentOS 7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---