You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2010/10/26 23:27:24 UTC
[jira] Created: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
MD5Hash provides a public factory method that creates an instance of MessageDigest
----------------------------------------------------------------------------------
Key: HADOOP-7009
URL: https://issues.apache.org/jira/browse/HADOOP-7009
Project: Hadoop Common
Issue Type: Improvement
Components: io
Affects Versions: 0.22.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Fix For: 0.22.0
MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926241#action_12926241 ]
Hudson commented on HADOOP-7009:
--------------------------------
Integrated in Hadoop-Common-trunk #496 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/496/])
HADOOP-7009. MD5Hash provides a public factory method that creates an instance of MessageDigest. Contributed by Hairong Kuang.
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-7009:
----------------------------------
Attachment: md5hash1.patch
Eli, thanks for your review! This patch adds javadoc to the method.
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang resolved HADOOP-7009.
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I've committed this!
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-7009:
----------------------------------
Attachment: md5hash.patch
Here is a simple patch that does this.
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925707#action_12925707 ]
Hairong Kuang commented on HADOOP-7009:
---------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appe
[exec] ar to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests framework compile.
[exec]
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925917#action_12925917 ]
Hudson commented on HADOOP-7009:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #405 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/405/])
HADOOP-7009. MD5Hash provides a public factory method that creates an instance of MessageDigest. Contributed by Hairong Kuang.
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925659#action_12925659 ]
Eli Collins commented on HADOOP-7009:
-------------------------------------
+1
Nit: getDigester needs a javadoc, and perhaps a name that suggests it returns a thread local?
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7009) MD5Hash provides a public factory
method that creates an instance of MessageDigest
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925722#action_12925722 ]
Hairong Kuang commented on HADOOP-7009:
---------------------------------------
All unit tests were passed. All 6 javadoc warnings are security-related and are unrelated to this patch. The patch is too trivial to have a unit test. I will commit it.
> MD5Hash provides a public factory method that creates an instance of MessageDigest
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-7009
> URL: https://issues.apache.org/jira/browse/HADOOP-7009
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: md5hash.patch, md5hash1.patch
>
>
> MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.