You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2013/08/20 01:49:12 UTC
svn commit: r1515671 - in
/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common:
CHANGES.txt src/main/conf/log4j.properties
src/main/java/org/apache/hadoop/conf/Configuration.java
Author: stevel
Date: Mon Aug 19 23:49:11 2013
New Revision: 1515671
URL: http://svn.apache.org/r1515671
Log:
HADOOP-9487 Deprecation warnings in Configuration should go to their own log or otherwise be suppressible
Modified:
hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt
hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
Modified: hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1515671&r1=1515670&r2=1515671&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/CHANGES.txt Mon Aug 19 23:49:11 2013
@@ -38,6 +38,9 @@ Release 2.3.0 - UNRELEASED
HADOOP-9866. convert hadoop-auth testcases requiring kerberos to
use minikdc. (ywskycn via tucu)
+ HADOOP-9487 Deprecation warnings in Configuration should go to their
+ own log or otherwise be suppressible (Chu Tong via stevel)
+
OPTIMIZATIONS
HADOOP-9748. Reduce blocking on UGI.ensureInitialized (daryn)
Modified: hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties?rev=1515671&r1=1515670&r2=1515671&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties (original)
+++ hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties Mon Aug 19 23:49:11 2013
@@ -131,6 +131,13 @@ log4j.appender.DRFAS.layout.ConversionPa
log4j.appender.DRFAS.DatePattern=.yyyy-MM-dd
#
+# hadoop configuration logging
+#
+
+# Uncomment the following line to turn off configuration deprecation warnings.
+# log4j.logger.org.apache.hadoop.conf.Configuration.deprecation=WARN
+
+#
# hdfs audit logging
#
hdfs.audit.logger=INFO,NullAppender
@@ -231,4 +238,5 @@ log4j.appender.RMSUMMARY.layout.Conversi
#log4j.appender.HSAUDIT.File=${hadoop.log.dir}/hs-audit.log
#log4j.appender.HSAUDIT.layout=org.apache.log4j.PatternLayout
#log4j.appender.HSAUDIT.layout.ConversionPattern=%d{ISO8601} %p %c{2}: %m%n
-#log4j.appender.HSAUDIT.DatePattern=.yyyy-MM-dd
\ No newline at end of file
+#log4j.appender.HSAUDIT.DatePattern=.yyyy-MM-dd
+
Modified: hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java?rev=1515671&r1=1515670&r2=1515671&view=diff
==============================================================================
--- hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java (original)
+++ hadoop/common/branches/branch-2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java Mon Aug 19 23:49:11 2013
@@ -153,6 +153,10 @@ import com.google.common.base.Preconditi
* will be resolved to another property in this Configuration, while
* <tt>${<i>user.name</i>}</tt> would then ordinarily be resolved to the value
* of the System property with that name.
+ * By default, warnings will be given to any deprecated configuration
+ * parameters and these are suppressible by configuring
+ * <tt>log4j.logger.org.apache.hadoop.conf.Configuration.deprecation</tt> in
+ * log4j.properties file.
*/
@InterfaceAudience.Public
@InterfaceStability.Stable
@@ -161,6 +165,9 @@ public class Configuration implements It
private static final Log LOG =
LogFactory.getLog(Configuration.class);
+ private static final Log LOG_DEPRECATION =
+ LogFactory.getLog("org.apache.hadoop.conf.Configuration.deprecation");
+
private boolean quietmode = true;
private static class Resource {
@@ -830,7 +837,7 @@ public class Configuration implements It
private void warnOnceIfDeprecated(String name) {
DeprecatedKeyInfo keyInfo = deprecatedKeyMap.get(name);
if (keyInfo != null && !keyInfo.accessed) {
- LOG.warn(keyInfo.getWarningMessage(name));
+ LOG_DEPRECATION.info(keyInfo.getWarningMessage(name));
}
}