You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/27 08:30:07 UTC
[GitHub] [rocketmq] drpmma opened a new pull request, #4386: [ISSUE #4384] Expand RocketMQ Topic/Group attributes
drpmma opened a new pull request, #4386:
URL: https://github.com/apache/rocketmq/pull/4386
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Topic and Group are important concepts in RocketMQ, but they are too simple to provide detailed information and more management ability. Therefore, there is a proposal to expand RocketMQ Topic/Group attributes.
## Brief changelog
Add attributes below:
* Topic Message Type
* Consume Timeout for PushConsumer
* Consume Retry Policy
* Max Retry Times
* Group Fifo Consume Flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4386: [ISSUE #4384] Expand RocketMQ Topic/Group attributes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4386:
URL: https://github.com/apache/rocketmq/pull/4386#issuecomment-1139428608
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4386](https://codecov.io/gh/apache/rocketmq/pull/4386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22b0625) into [5.0.0-beta](https://codecov.io/gh/apache/rocketmq/commit/52e059e281d3468789d82074f097093c9c7126a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52e059e) will **decrease** coverage by `0.07%`.
> The diff coverage is `38.70%`.
```diff
@@ Coverage Diff @@
## 5.0.0-beta #4386 +/- ##
================================================
- Coverage 43.01% 42.94% -0.08%
- Complexity 6016 6028 +12
================================================
Files 796 801 +5
Lines 56943 57055 +112
Branches 7796 7800 +4
================================================
+ Hits 24495 24501 +6
- Misses 29240 29333 +93
- Partials 3208 3221 +13
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tmq/common/subscription/CustomizedRetryPolicy.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3Vic2NyaXB0aW9uL0N1c3RvbWl6ZWRSZXRyeVBvbGljeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mq/common/subscription/ExponentialRetryPolicy.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3Vic2NyaXB0aW9uL0V4cG9uZW50aWFsUmV0cnlQb2xpY3kuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ols/command/consumer/UpdateSubGroupSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29uc3VtZXIvVXBkYXRlU3ViR3JvdXBTdWJDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/rocketmq/common/TopicConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vVG9waWNDb25maWcuamF2YQ==) | `56.39% <37.93%> (+6.82%)` | :arrow_up: |
| [...rocketmq/common/subscription/GroupRetryPolicy.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3Vic2NyaXB0aW9uL0dyb3VwUmV0cnlQb2xpY3kuamF2YQ==) | `58.33% <58.33%> (ø)` | |
| [...q/common/subscription/SubscriptionGroupConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3Vic2NyaXB0aW9uL1N1YnNjcmlwdGlvbkdyb3VwQ29uZmlnLmphdmE=) | `61.90% <92.30%> (+6.34%)` | :arrow_up: |
| [...va/org/apache/rocketmq/common/TopicAttributes.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vVG9waWNBdHRyaWJ1dGVzLmphdmE=) | `90.00% <100.00%> (+90.00%)` | :arrow_up: |
| [...he/rocketmq/common/attribute/TopicMessageType.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vYXR0cmlidXRlL1RvcGljTWVzc2FnZVR5cGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...etmq/common/subscription/GroupRetryPolicyType.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3Vic2NyaXB0aW9uL0dyb3VwUmV0cnlQb2xpY3lUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/rocketmq/pull/4386/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4386?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4386?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [52e059e...22b0625](https://codecov.io/gh/apache/rocketmq/pull/4386?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zhouxinyu merged pull request #4386: [ISSUE #4384] Expand RocketMQ Topic/Group attributes
Posted by GitBox <gi...@apache.org>.
zhouxinyu merged PR #4386:
URL: https://github.com/apache/rocketmq/pull/4386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4386: [ISSUE #4384] Expand RocketMQ Topic/Group attributes
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4386:
URL: https://github.com/apache/rocketmq/pull/4386#issuecomment-1139428644
[](https://coveralls.io/builds/49509760)
Coverage increased (+0.04%) to 47.197% when pulling **22b062565f4dacd1e9cc5d2a8b824e854fd76f77 on drpmma:feature/resource** into **52e059e281d3468789d82074f097093c9c7126a6 on apache:5.0.0-beta**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org