You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aaron T. Myers (Created) (JIRA)" <ji...@apache.org> on 2012/01/26 08:42:40 UTC
[jira] [Created] (HDFS-2841) HA: HAAdmin does not work if security
is enabled
HA: HAAdmin does not work if security is enabled
------------------------------------------------
Key: HDFS-2841
URL: https://issues.apache.org/jira/browse/HDFS-2841
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
Priority: Critical
Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2841) HA: HAAdmin does not work if
security is enabled
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196887#comment-13196887 ]
Hudson commented on HDFS-2841:
------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #64 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/64/])
Amend HDFS-2841 to include new file which was omitted from original commit.
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237971
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSHAAdmin.java
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2841) HA: HAAdmin does not work if
security is enabled
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196396#comment-13196396 ]
Aaron T. Myers commented on HDFS-2841:
--------------------------------------
Whoops! Thanks for pointing that out, Hari. I've just committed an amendment to include the new file.
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2841) HA: HAAdmin does not work if security
is enabled
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-2841:
---------------------------------
Attachment: HDFS-2841-HDFS-1623.patch
Here's a patch which addresses the issue. No tests are included since it's mostly a refactor, and it's not possible to write tests to verify that it works with Kerberos enabled.
Testing:
I ran a Kerberized, HA-enabled pseudo cluster and verified that I could run `hdfs haadmin -transitionToActive', etc and have it work. I also ran a few client commands and verified that client failover continues to work with security enabled, which is a lovely surprise. I also ran TestHAAdmin, which passed.
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2841) HA: HAAdmin does not work if
security is enabled
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195735#comment-13195735 ]
Uma Maheswara Rao G commented on HDFS-2841:
-------------------------------------------
Aaron, Patch looks great.
I also verified the patch, it works fine.
small nit:
following code should be formatted to single line.
{code}
throw new IOException(
- "Couldn't create proxy provider " + failoverProxyProviderClass, e);
+ message, e);
{code}
+1 from my side after addressing this nit.
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2841) HA: HAAdmin does not work if
security is enabled
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195835#comment-13195835 ]
Todd Lipcon commented on HDFS-2841:
-----------------------------------
+1
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2841) HA: HAAdmin does not work if
security is enabled
Posted by "Hari Mankude (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196389#comment-13196389 ]
Hari Mankude commented on HDFS-2841:
------------------------------------
Aaron,
It looks like DFSHAAdmin.java (new file) did not get checked into hdfs-1623.
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2841) HA: HAAdmin does not work if security
is enabled
Posted by "Aaron T. Myers (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers resolved HDFS-2841.
----------------------------------
Resolution: Fixed
Fix Version/s: HA branch (HDFS-1623)
Hadoop Flags: Reviewed
Thanks a lot for the reviews, Uma and Todd. I've just committed this to the branch and addressed Uma's nit on commit.
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2841) HA: HAAdmin does not work if
security is enabled
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196096#comment-13196096 ]
Hudson commented on HDFS-2841:
------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #63 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/63/])
HDFS-2841. HAAdmin does not work if security is enabled. Contributed by Aaron T. Myers.
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237534
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/bin/hadoop
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
> Key: HDFS-2841
> URL: https://issues.apache.org/jira/browse/HDFS-2841
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Critical
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} annotation, it specifies the Common server principal, which is intended to be overridden at run-time with the value of the correct principal (e.g. as is done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira